-
Guest78835If you have time, please review the open pull requests. There are many changes waiting to go in that cannot be merged because they are not reviewed :(
-
Guest78835for example repo.getmonero.org/monero-project/monero-site/merge_requests/1149 needs even just a rubberstamp approval
-
Guest78835The PR that need to be approved: 1164 1170 1165 and 1149
-
Guest78835When reviewing please leave a comment instead of a thumb up. So that the review is visible (it's also hard to keep track of when the thumb up was left, if before or after changes are introduced)
-
xmr-prerciccione opened pull request #1171: move 2 blog post images to blog/assets for consistency
-
xmr-pr
-
xmr-prBestChange opened issue #1026: Listing on
-
xmr-pr
-
sgp_ErCiccione / Guest78835: done
-
Guest78835sgp_ i see you reviewed all the pt-br translations. do you speak portuguese?
-
Guest78835btw, thanks for the review, but we need 1164 1170 1165 and 1149 reviewed more than the translations.If you have time, a comment on those will be appreciated :)
-
sgp_No, but it roughly looks good to me. I can read Spanish and I tested some strings with Google to make sure I was in the right ballpark
-
Guest78835Alright, better wait for the review of a native speaker before adding them to the merge queue then
-
sgp_So what I'm basically saying is that it appears to be a legit translation worth a real translator's time :)
-
Guest78835:)
-
sgp_is there anything I missed?
-
Guest788351164 1170 1165 and 1149 need to be reviewed
-
sgp_good, I hit all of those
-
Guest78835Thanks sgp_! Please leave a comment next time (even a simple ACK), so that it's possible to know when the PR was reviewed and if comments/commits where addeed after or before :)
-
sgp_ok, I didn't realize that was necessary. I miss GitHub's review feature
-
Guest78835.merge+ #1171 #1164 #1165
-
xmr-prAdded
-
Guest78835yeah, gitlab offer the "approve" button in their paid service. Which is sad
-
sgp_:(
-
Guest78835.merges
-
xmr-pr#1149 #1155 #1164 #1165 #1167 #1171
-
selstaSo gitlab does not offer all features in their self hosted version?
-
Guest78835no selsta, they have an enterprise edition with all the cool stuff. Buying an enerprise license is out of question imo, would be crazy expensive