22:51:37 <selsta> GUI compiles with `-- Building without build tag`
22:51:43 <selsta> so that explains it
22:52:42 <moneromooo> Still doesn't show the source hash. I'm thinking maybe there was no source tarball for the GUI at the time so it falls back.
22:54:02 <selsta> It does show the source hash?
22:54:12 <selsta> SHA256(/Users/selsta/Downloads/monero-gui-source-v0.15.0.1.tar.bz2)= 260edb14b1614e5b862b761eccd6259c1f0914d978016b227a9f4558059e4866
23:07:12 <moneromooo> s/n\'t//
23:08:14 <moneromooo> What does the GUI pas as parameters to get_update_url ?
23:11:07 <selsta> GUI calls WalletManager::checkUpdates with ("monero-gui", "gui") as parameters
23:11:17 <selsta> Can you explain where you think that there’s a bug?
23:12:10 <selsta> because I think everything is working ok we just have to set BUILD_TAG
23:12:53 <moneromooo> I don't know.
23:15:03 <selsta> ok I fixed it in https://github.com/monero-project/monero-gui/pull/2485
23:15:24 <selsta> https://usercontent.irccloud-cdn.com/file/2GEWXb6K/Screenshot%202019-11-25%20at%2000.15.18.png
23:21:01 <moneromooo> lol, it looks like it's trolling you, telling you you have ZERO monero :D
23:21:40 <selsta> lol a lot of people complained about this
23:22:08 <selsta> some even had the suspicion that the wallet is built for whales
23:34:37 <selsta> I found a  minor bug with get_update_url :D
23:40:18 <selsta> https://github.com/monero-project/monero/pull/6178
23:40:25 <selsta> that was the bug you were looking for moo :P
23:43:36 <moneromooo> I don't think so, since the original filename had "win-x64" or similar, and not "source". Still a bug though, thanks.
23:44:04 <selsta> now I get what you mean
23:44:44 <selsta> the GUI url was manually constructed by looking at the OS, that’s why it showed the win-x64 download
23:45:44 <moneromooo> OK, explains why it works for monerod then. Thanks :)
23:46:05 <selsta> I fixed it in #2485
23:48:57 <moneromooo> Still seems fishy. If the build tag isn't set, it should use source. It displayed win-x64.
23:50:32 <selsta> It would have displayed source but only the hash part from the checkUpdates response was used.
23:50:54 <selsta> The GUI saw that it was run on Windows and had the win-x64 URL hardcoded, it didn’t use the response.
23:51:01 <moneromooo> Ah. OK then.
23:51:06 <moneromooo> Thanks for fixing :)