05:38:51 <fluffypony> repro builds wouldn't prevent any of that
05:39:04 <fluffypony> people downloading don't check hashes, and that's not going to change
05:39:16 <fluffypony> the auto-updater is the closest thing we can do to checking it for them
09:10:53 <selsta> ^ also true
09:12:38 <fluffypony> all that repro builds do is prevent the person finalising the build from compromising it
09:12:55 <fluffypony> it's not like when binaryFate uploads a binary any of us go and disassemble it 
09:13:02 <fluffypony> ain't nobody got time fo date
09:13:03 <fluffypony> *dat
09:13:11 <selsta> fluffypony: btw do you have any idea how we could move the mac archive from tar.bz2 to .dmg while not breaking updater?
09:13:22 <selsta> a redirect maybe? not sure if the software would follow it
09:13:29 <fluffypony> hmmmm
09:13:35 <fluffypony> we could test a redirect 
09:13:52 <fluffypony> the problem is that you can automatically unpack a tar.bz2 and overwrite the existing one
09:14:02 <fluffypony> I don't know if there are automation tools for handling a DMG
09:14:05 <fluffypony> I mean, there must be
09:14:10 <fluffypony> but the existing code won't know what to do with it
09:14:24 <selsta> don’t think we have this code
09:14:28 <selsta> or not aware of it
09:14:35 <selsta> the updater only downloads the new file
09:14:36 <fluffypony> do the notary tools insist on producing a .dmg?
09:14:39 <selsta> yes
09:14:40 <fluffypony> I thought they produce .apps
09:14:46 <fluffypony> and the .app is signe
09:14:48 <fluffypony> *signed
09:14:48 <selsta> .dmg or .zip
09:15:05 <fluffypony> we can unpack the .zip and repack it as .tar.bz2 without losing the sig
09:15:12 <fluffypony> I'm 25% certain
09:15:13 <fluffypony> lol
09:15:20 <selsta> yea does not work lol
09:15:35 <fluffypony> blah
09:15:36 <selsta> the .dmg gets signed and the .app
09:15:40 <selsta> apparently
09:15:46 <fluffypony> but the .zip doesn't get signed
09:15:50 <fluffypony> or is it a zip of a dmg
09:16:02 <selsta> no, but there were issues with the .zip
09:16:09 <selsta> that I don’t remember currently
09:16:15 <selsta> .dmg was better
09:17:05 <fluffypony> are these signed per-machine or a single universal sig?
09:17:40 <fluffypony> (app store app installs are signed for that machine only, afaik)
09:20:34 <selsta> I think universal
09:20:50 <selsta> I remember the issue with .zip now, you can’t staple the result
09:21:04 <selsta> meaning that apple’s server get pinged
09:21:25 <selsta> with dmg you can staple the "signature" and it also works offline without pinging apple
09:21:46 <selsta> we had the idea of doing it in two steps
09:22:10 <selsta> add the code to download .dmg instead of .tar.bz2 in the next release
09:22:21 <selsta> and then the release afterwards we bundle it as dmg
09:22:33 <selsta> but this will only work for those who updated to the latest version
10:11:39 <fluffypony> I think we can expect teething issues for now
10:11:40 <fluffypony> so don't expect perfect forward compatibility 
10:11:53 <fluffypony> we can add the code in, and do the next one as a .tar.bz2 
10:11:56 <fluffypony> and then .dmg thereafter
10:12:11 <fluffypony> we just need to automatically mount the dmg -> copy the .app to where the current one is
10:12:15 <fluffypony> (which may not be /Applications)
10:20:17 <selsta> fluffypony: the auto updater only verifies the file and opens the file explorer, no auto extracting currently
10:20:30 <selsta> so should be ok with .dmg
10:21:14 <fluffypony> ah ok
10:21:20 <fluffypony> is the plan to go full auto-update eventually?
10:21:33 <selsta> maybe, probably not trivial to do cross platform
10:22:02 <fluffypony> would require a second binary that spins up -> deletes existing app -> replaces it with the new one -> restarts app
10:24:33 <selsta> would be a nice to have in the future
10:29:11 <dsc_> possibly make this a seperate project that is able to manage both monero-gui and monero binaries (starting, stopping, updating)
10:30:19 <dsc_> we need to create Steam/Battle.net, for crypto
10:31:17 <dsc_> half joking, half not
13:34:32 <fluffypony> dsc_: https://github.com/moneromooo-monero/monero-update
13:34:50 <fluffypony> needs to be picked up, but moneromooo already started it
13:35:20 <fluffypony> if someone wants to run with it I'm happy to re-home it to the main GitHub
13:36:05 <moneromooo> I have a patch for it to work with the GUI. I'm just waiting for repro builds to push it.
17:42:02 <kinghat[m]> i was thinking of only checking the binary hashes from two or more locations and thats it. with immutable git repo to prevent what pony was talking about backdating commits and repo builds when that happens. ill stop bringing it up as the updater is already overkill.a
17:42:09 <kinghat[m]>  * i was thinking of only checking the binary hashes from two or more locations and thats it. with immutable git repo to prevent what pony was talking about backdating commits and repo builds when that happens. ill stop bringing it up as the updater is already overkill.
20:31:21 <luigi1111w> .merges
20:31:21 -xmr-pr- #2933 #2937 #2947 #2950 #2959 #2961 #2962 #2963
21:13:05 <luigi1111w> 2933 conflicts
21:13:29 <selsta> xiphon: ^
21:17:24 <luigi1111w> 2963 also
21:32:09 <selsta> we might have to revert 2947, it seemed like a simple patch and I also tested it a bit but it doesn’t fully work as expected.
21:54:44 <xiphon> luigi1111w: resolved merge conflicts