07:00:26 -xmr-pr- bosomt opened issue #2960: QR code overlaps GUI on Trezor T display 07:00:27 -xmr-pr- > https://github.com/monero-project/monero-gui/issues/2960 11:22:00 .merges 11:22:00 Merge queue empty 11:22:18 .merge+ #2933 11:22:19 ... 11:22:23 .merges 11:22:24 -xmr-pr- #2933 11:30:26 -xmr-pr- xiphon opened pull request #2961: cmake: downgrade minimum required boost version to 1.58 11:30:27 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/2961 11:44:01 .merge+ #2959 11:44:01 Added 11:45:27 -xmr-pr- xiphon opened pull request #2962: cmake: fix USE_DEVICE_TREZOR option 11:45:27 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/2962 12:57:48 I noticed that DaemonManager does not trigger signals because monerod is started with startDetached(). 12:57:57 Output logging from the daemon to the Settings -> Log page is broken. 12:58:10 And stateChanged is also never executed. This causes an issue where if monerod crashes during startup it takes ~2 minutes before the wallet gives up trying to connect to the daemon. 12:58:26 Ideally the wallet detects that monerod has crashed (by checking for exitcode != 0) and show the daemonStartFailure dialog with an error message. This can be done by connecting to the finished signal. 12:58:40 But, for signals to work the daemon has to be started with start() and the --detach flag removed. 12:58:53 That means that the daemon will stop when the wallet is exited, so the prompt that asks to keep monerod running will break. 12:59:15 A workaround is to stop monerod and then start it again detached when the wallet is closed. 12:59:24 I'm working on a patch to address all of this. 13:17:54 Not sure this is a good way 13:18:16 And the workaround idea doesnt' sound good to me 13:19:20 "I'm working on a patch to address all of this." -> please consider to submit multiple separate PRs 13:19:34 What would be a better way? 13:19:41 "please consider to submit multiple separate PRs" -> Sure 13:20:03 Regarding the daemon - i see absolutelu no reaso to start it detached 13:20:12 Just start it always attached 13:20:17 And the detach when necessary 13:20:27 So remove the functionality to keep it running on wallet close? 13:20:33 No 13:20:44 Just detach from it 13:21:06 I looked for that, QT doesn't provide an API afaik 14:08:50 xiphon: https://lists.qt-project.org/pipermail/development/2019-February/035333.html 14:12:30 So it appears that either we don't have output logging, detecting crashes or state changes. Or we can't keep the daemon running on exit (without a workaround). 14:21:35 Imo it would be very helpful to show why monerod failed to start. 14:21:52 Just yesterday I spent 2 hours debugging with someone to figure out why the daemon wouldn't start in their GUI. 14:21:52 It's hard to tell if it's a corrupted blockchain, incorrect daemon flags, AV killing the process, or as it turns out, an issue in pop_block() without output logs or error messages. 14:22:27 Why not instruct user to start monerod manually if they want to keep it running or apply ugly workaround? 15:01:51 "It's hard to tell if it's a corrupted blockchain, incorrect daemon flags, AV killing the process, or as it turns out, an issue in pop_block() without output logs or error messages." -> all this should be in monerod logs 15:02:00 except "AV killing the process" 15:05:48 ^ but "output logs or error messages" won't help you either in that case 15:22:03 "all this should be in monerod logs" -> The user isn't going to look for monerod logs (or even know that they exist) if they don't know that monerod crashed. Right now when monerod crashes they get nothing. It hangs for two minutes and then the status says "Disconnected". Not very helpful and not very actionable. 15:27:11 "but "output logs or error messages" won't help you either in that case" -> probably exits with a return code that is not 0 or 1, and the absence of an error message can give it away 16:28:30 .merges 16:28:30 -xmr-pr- #2933 #2959 16:29:55 .merge+ #2937 #2947 #2950 #2961 #2962 16:29:55 Added