00:57:35 <Bobtette> moneromooo, Now there are a lot of tx when i do print_pool_sh, looks like those are all the tx in the network still need to get confirmed?
00:58:27 <moneromooo> Yes.
01:21:00 <Bobtette> Any way i can force this pending tx to get failed status so i know it will not try to push this tx again and again?
01:21:16 <moneromooo> Does it show pending or failed in monero-wallet-cli ?
01:35:36 <Bobtette> In GUI it shows pending. I´ll check CLI
01:45:27 -xmr-pr- selsta opened pull request #2950: LeftPanel: simpifly color binding
01:45:27 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/2950
01:50:56 <Bobtette> moneromooo, In CLI it shows as failed.
01:51:17 <selsta> Possible that the GUI can’t display failed transactions.
01:56:48 <Bobtette> So i assume its  safe to re-send the transaction.
02:00:10 <selsta> any way to simulate a failed transaction?
02:07:47 <Bobtette> No idea.
02:16:31 <selsta> If I manage to simulate a failed tx I can add GUI support for it :P
10:56:12 <moneromooo> For a failed tx: start the daemon with --offline, send one, then flush_txpool_, then let the wallet refresh a couple time.
20:15:26 -xmr-pr- rating89us opened issue #2951: Transfer: amount field should also accept comma as decimal separator
20:15:27 -xmr-pr- > https://github.com/monero-project/monero-gui/issues/2951
21:00:27 -xmr-pr- rating89us opened issue #2952: Hardware wallet: request to plug in the device only when sending trans...
21:00:27 -xmr-pr- > https://github.com/monero-project/monero-gui/issues/2952
21:07:05 <selsta> moneromooo: E: failed to get output distribution, request = Daemon reports suspicious number of rct outputs
21:07:10 <selsta> when trying to send with --offline
21:16:10 <selsta> ok managed to do it
21:53:51 <moneromooo> Do you know why then ?
21:55:01 <selsta> yep my daemon was like 1 day behind
21:55:09 <selsta> so I synced up and restarted with --offline
21:56:11 <selsta> now I have the problem that is_failed always evaluates to true
21:56:17 <selsta> https://github.com/monero-project/monero/blob/master/src/wallet/api/transaction_history.cpp#L200
21:57:07 <selsta> does ^ look correct?
21:58:23 <moneromooo> Failed it set if the tx was not seen in the chain nor the pool for two refreshes.
21:59:17 <moneromooo> Does it work in monero-wallet-cli ?
21:59:21 <selsta> yes
22:00:06 <moneromooo> I assume you copied the logic off monero-wallet-cli ?
22:00:19 <selsta> the logic did already exist
22:00:34 <selsta> the one I linked before
22:01:46 <moneromooo> Then the most likely seems that the refresh calls are wrong.
22:01:53 <moneromooo> Was that particular tx mined ?
22:02:41 <selsta> nope
22:02:58 <selsta> directly after sending both pending and failed are both true in wallet2_api
22:03:06 <selsta> (without getting mined yet)
22:03:12 <moneromooo> And it's in the txpool ?
22:03:50 <selsta> yes
22:03:54 <selsta> I can see it on xmrchain.net
22:04:10 <moneromooo> Then you possibly refreshed the chain but not the txpool, so as far as it's concerned, it sees it in neither.
22:04:37 <moneromooo> Bump log level in monerod to see which RPC are being called.
22:04:48 <moneromooo> *rpc*:DEBUG ought to do
22:06:53 <selsta> interesting
22:07:00 <selsta> using my local node it works
22:07:06 <selsta> but my remote node (restricted) does not
22:07:55 <selsta> I tested CLI with my local node
22:11:10 <moneromooo> Ah, maybe restricted mode hides the tx.
22:11:24 <moneromooo> (If received by RPC rather than P2P)
22:11:48 <moneromooo> Yes, it must do. You wouldn't want people to see what you send.
22:12:23 <selsta> CLI correctly sets it to false even when using a restricted remote node
22:12:31 <selsta> s/false/failed/
22:13:07 <moneromooo> You said it was always setting to failed, so maybe it's accidentially setting it correctly.
22:13:22 <selsta> will test once my balance is unlocked
22:14:57 <selsta> `pending    out`
22:14:58 <selsta> looks good
22:15:01 <selsta> in CLI
22:15:43 <selsta> oh well will maybe ask xiphon to take a look at it, starting to get confused
22:25:45 <selsta> if I create the tx with the GUI + restricted node -> open same wallet in CLI it will say failed while still pending
22:26:00 <selsta> if I do the same in CLI + restricted node it will say correctly pending
22:26:08 <selsta> guess that’s the problem
22:26:31 <moneromooo> The GUI probably set it wrong before the wallet has a chance to do anything.
22:26:45 <selsta> with local node everything is ok in both CLI / GUI
22:27:51 <selsta> https://github.com/monero-project/monero/blob/master/src/wallet/api/transaction_history.cpp#L219
22:27:56 <selsta> here is_failed doesn’t even get set
22:28:02 <selsta> so maybe it defaults to true?
22:28:18 <moneromooo> No idea without looking.
22:29:45 <moneromooo> I looked. Looks like pending when created.
22:38:28 <selsta> yep the pending flag is correct
22:38:33 <selsta> the failed one is just the problem
22:40:25 <moneromooo> Flag ? It's an enum. It's one or the other.
22:40:31 <moneromooo> (or the third)
22:41:00 <selsta> on the GUI side it’s a flag
22:41:07 <selsta> see line 207
22:42:10 <moneromooo> OK, I see it, but it's initialized from the enum AFAICT.
22:42:19 <selsta> yes
23:30:27 -xmr-pr- selsta opened pull request #2953: [do not merge] History: add failed transaction state
23:30:27 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/2953