15:29:34 <selsta> .merges
15:29:34 -xmr-pr- #2927 #2928
15:30:00 <selsta> .merge+ #2941 #2942 #2943
15:30:00 <xmr-pr> Added
17:15:26 -xmr-pr- jon-ryan opened issue #2944: Not getting rewards for mining
17:15:27 -xmr-pr- > https://github.com/monero-project/monero-gui/issues/2944
17:40:28 <selsta> moneromooo: could you take a look at this? https://github.com/monero-project/monero-gui/pull/2943
17:40:45 <selsta> you reviewed the first part of this PR a while ago and I would prefer a second approval
17:43:17 <selsta> .merge- #2943
17:43:18 <xmr-pr> Removed
17:49:23 <moneromooo> I left a comment. Looks ok to me, but that's not saying much.
17:54:48 <selsta> thanks
18:07:43 <kinghat[m]> selsta should the hash thats checked come from two different locations? so https://web.getmonero.org/downloads/hashes.txt and then maybe github?
18:09:37 <selsta> I think the current system is already overkill so adding the benefit of adding second location is negligible
18:10:09 <selsta> the hash is worthless anyway without two signatures
18:14:00 <selsta> kinghat[m]: using github would also mean the gui would ping github which they could use for tracking
18:17:25 <kinghat[m]> guess you could check through tor or something
18:23:57 <selsta> It would not add any security. If one maintainer gets fully compromised than they could replace both text files.
18:24:29 <selsta> That’s why we added the second signature, two maintainers getting fully compromised is rather unlikely.
18:26:50 <kinghat[m]> wouldnt github show a public trace of the compromise though?
18:27:23 <fluffypony> not if you force-push and backdate the PR
18:27:29 <fluffypony> s/PR/commit
18:34:49 <kinghat[m]> it doesnt show publicly that you did that action today or is the public record derived from the changed date? like ya the commits date is this but you did it today, kind of thing.
18:36:21 <selsta> don’t think it does
18:45:26 -xmr-pr- knaccc opened issue #2945: On restore from seed, balance changes from ?.?? to 0.0000... mid-scan
18:45:27 -xmr-pr- > https://github.com/monero-project/monero-gui/issues/2945
18:49:03 <fluffypony> kinghat[m]: no it doesn't
18:49:12 <fluffypony> it's easy to fake git data and to force-push it to a repo
18:49:27 <sarang> ^
18:49:56 <fluffypony> the reason something like Monero isn't affected by that is because tons of people have a copy of the repo
18:49:57 <fluffypony> and would notice a force push
18:49:58 <fluffypony> but they wouldn't notice it any faster than noticing that the hashes had changed on the site
18:51:20 <sarang> This is also where repro builds come into play
18:51:45 <sarang> If you think that some other source host or builder is compromised, built it yourself and check
18:51:55 <sarang> (and see that the git hashes differ too, if you're checking commits)
18:55:33 <kinghat[m]> thanks for the education guys 🙏
18:57:57 <selsta> .merge+ #2943
18:57:57 <xmr-pr> Added
19:02:08 <selsta> .merges
19:02:08 -xmr-pr- #2927 #2928 #2941 #2942 #2943
22:15:26 -xmr-pr- rating89us opened pull request #2947: main: update balance only when wallet is synced
22:15:27 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/2947