12:17:26 <ErCiccione[m]> Comment from rbrunner on weblate:
12:17:33 <ErCiccione[m]> The whole group of strings along the lines of "x <time unit> ago*, all from the Utils.js source file, run into translation problems for German: The code implements a pattern of generating a number plus an English string (e.g. 10 minutes ago) which does not work cleanly for German, where it should be "vor" plus number plus "<time units>", e.g. vor 10 Minuten
12:18:00 <ErCiccione[m]> Is it possible to do something tofix that?
12:30:27 <moneromooo> <joke>10 Minuten (*vor)</joke>
12:40:29 <rbrunner> Well, I think what I proposed now, which results in outputs like "10 Minuten seither" is not a pretty, but a usable compromise for the time being, without any hastened code changes
12:57:19 <ErCiccione[m]> Yeah but the problem probably exists for other languages as well, would be better to fix it somehow. But i understand it's tricky to find a good format in this case
13:00:39 <moneromooo> Not really. With QML, you can have reference to argument indices, so you can do, eg: print("%1 %2", seconds, idiomatic_expression). German can turn "%1 %2" to "%2 %1".
13:01:13 <moneromooo> Actually, don't even need that. Just "%u ago" would work, as it'd be changed to "vor %u".
13:01:43 <moneromooo> The "Minuten" also has to go as a %s.
13:01:52 <moneromooo> Since I assume you also have hours, etc.
13:03:40 <rbrunner> Yes, string + placeholder for the number to go in would work nicely. It needs several strings (seconds, hours, days), but only 1 placeholder for the number.
13:07:25 <ErCiccione[m]> Cool, good to know. Hopefully somebody will make the change. No need to have it for this release, but after, definitely.
14:00:27 -xmr-pr- rating89us opened pull request #2914: Redesign wallet mode selection
14:00:27 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/2914
14:41:19 <selsta> .merges
14:41:20 <xmr-pr> Merge queue empty
14:42:21 <selsta> .merge+ #2910 #2911 #2912 #2913
14:42:22 <xmr-pr> ...
15:04:59 <selsta> ErCiccione[m]: does the lupdate command take long?
15:05:51 <selsta> I tried something out but now it’s taking like 10+ mins to update
15:06:33 * selsta waiting patiently
15:14:42 <ErCiccione[m]> No, it should be almost immediate
15:15:39 <selsta> hmm it does not work
15:16:14 <selsta> apparently lupdate supports plurals
15:16:20 <ErCiccione[m]> try `lupdate -pro monero-wallet-gui.pro -ts translations/monero-core.ts -no-obsolete`
15:16:20 <selsta> I’m interested if weblate also supports it
15:16:47 <ErCiccione[m]> it does afaik
15:17:30 <selsta> yea it does not work on my system somehow
15:17:53 <selsta> will downgrade my Qt version
15:18:11 <ErCiccione[m]> weird
15:24:16 <selsta> hmm does not work :(
15:24:40 <selsta> https://paste.debian.net/hidden/3b0ac56f/
15:24:47 <selsta> and then it gets stuck
15:25:17 <selsta> same without -pluralonly
15:57:49 <selsta> ErCiccione[m]: can you test how this looks in weblate? https://github.com/monero-project/monero-gui/pull/2915
15:58:10 <selsta> if I understand it correctly we should be able to specify the correct plurals for every language (including english)
15:58:21 <selsta> even if they have 3+ plural forms
15:58:59 <selsta> https://doc.qt.io/qt-5/i18n-plural-rules.html
16:00:27 -xmr-pr- selsta opened pull request #2915: Utils: simplify for translations
16:00:27 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/2915
16:32:48 <ErCiccione[m]> I think i had that error in past, but i don't remember why
16:33:34 <ErCiccione[m]> i will test that PR on my weblate instance later today or tomorrow. About the plurals, i don't know much about it, i have to look it up, but weblate seem to be already using them.
16:39:46 <selsta> ty