03:19:14 thanks luigi1111! 03:20:03 should I repost my messages I sent before recieving voice? I can't see them if I view the chat from a different IRC client, so I assume they weren't delivered to everyone? 03:20:13 yes 03:24:43 Uploaded file: https://uploads.kiwiirc.com/files/679be95f472f138ff85c9e8210028659/pasted.txt 03:24:58 Hi there :) a few weeks ago I messaged and recieved some help regarding integrated payment addresses for my local music streaming app. I'm pleased to report it seems to mostly be working! However when I was doing some testing yesterday I noticed a weird issue, for some reason transactions from one testnet wallet to another would appear, and then 03:24:58 disappear! I've tested and verified a few times that the following sequence of steps causes a transaction to disappear from the wallet it is visible on the testnet block explorer though: 03:25:04 1. I start up monerod using the xmrto/monero:v0.17.2.0 docker image 03:25:04 2. I create two testnet wallets (A, B) and connect to that local daemon 03:25:05 3. I make a transfer from wallet A -> B using the GUI wallet 03:25:05 4. I can see the transfer (0 conf) in wallet B in the GUI wallet 03:25:06 5. I wait a few minues and the transfer which was there before no longer appears in wallet B in the GUI wallet. 03:25:07 I have really specific security question. Is this a good place to ask? 03:25:07 Are there security flaws for using the Monero wallet private key also for a crypto lock login system (https://github.com/monero-ecosystem/Monero-Crypto-Lock)? 03:25:13 The daemon printed the following message: monerod_1 | 2021-05-08 02:02:51.514 E failed to find tx meta: <93ec0eb675eda24e1b898933341bdd097fcb5f513ca28e354c50f6b23666ed1f> (will only print once) 03:25:18 I have uplaoded a video of the process here (you should skip the few minutes in the middle where I wait for it to dissapear): https://uploads.kiwiirc.com/files/d4cdd6fcf283c211791adfd356119422/2021-05-08%2009-57-58.mkv 03:25:26 Restarting the deamon (and also running the latest release using the native binaries from getmonero) does not make the transaction appear in the GUI. 03:26:11 I have really specific security question. Is this a good place to ask? 03:26:11 Are there security flaws for using the Monero wallet private key also for a crypto lock login system (https://github.com/monero-ecosystem/Monero-Crypto-Lock)? 06:45:41 HennyH: check if your restore height is from the future 06:45:55 inside Settings -> Info look for "wallet restore height" 06:46:19 if it is then the GUI will skip transactions 06:54:55 selsta to be safe I went and changed the restore height to 2021-05-01 using the GUI, it resynched + I tried running the rescan and it still does not show up 06:55:46 HennyH: what number is inside "Wallet restore height"? 06:56:40 1728577 hmm which is greater than the current testnet height of 1717241 06:56:45 i think you have found the issue! 06:57:05 testnet has incorrect date -> height conversion currently 06:57:06 perhaps when you create a testnet wallet using the GUI it miscalculates the restore height? 06:57:13 yep 06:57:20 yes due to rollbacks 06:57:48 thank you! It would have taken me a _very_ long time to figure this out myself 06:58:00 https://github.com/monero-project/monero/pull/7682 06:58:02 I suppose the hint was that once it disspeared from the mempool it stopped showing up in the wallet 07:00:19 I am so happy now, my tipping code is now working :D thank you! 07:10:14 how does the wallet RPC account for the restore height when searching for transactions? It seems that the wallet RPC doesn't pick them up:{ 07:10:14 "json_rpc": "2.0", 07:10:14 "id": "0", 07:10:15 "method": "get_transfers", 07:10:15 "params": { 07:10:16 "in": true, 07:10:17 "out": true, 07:10:17 "pending": true, 07:10:17 "failed": true, 07:10:18 "pool": true, 07:10:19 "filter_by_height": true, 07:10:19 "min_height": 1, 07:10:19 "max_height": 1717246 07:10:20 } 07:10:20 } 07:10:27 { 07:10:27 "id": "0", 07:10:28 "jsonrpc": "2.0", 07:10:28 "result": {} 07:10:29 } 07:10:58 removing the "filter_by_height" has an empty result too, I checked that get_address returned the address of the wallet I have open in the GUI 07:16:35 HennyH: is it the same wallet file? 07:17:36 I'm not super familiar with wallet RPC but look for an option to set restore height, could be the same issue 07:19:33 weird, it was, I copy and pasted it and when i opened in the GUI it said 1700000 for the restore height (like i had set it to), but i had to reset it again for it to update. Basically I have C:\Users\...\Documents\Monero\wallets (default windows GUI location), and then I copied those wallet files into C:\ProgramData\bitmonero\wallets which is the 07:19:34 data directory I mounted with the docker image. It looks like maybe you can't just copy-paste the wallet files :/ 07:20:07 I then opened that wallet file in ProgramData\bitmonero\wallets with the windows GUI and set the height to 1700000 again and it now works via RPC 07:20:30 I'll just mount my windows \wallets directory to /bitmonero/wallets or whatever in the container as well 09:32:48 would you know why MoneroOutgoingTransfer object in MoneroTxWallet does not always have destinations ? 10:35:34 I finished a RandomX implementation in pure Rust (not a binding to the C code). This is the first implementation in Rust that I'm aware of: https://github.com/Ragnaroek/mithril Feedback is welcomed :) 13:41:37 .merges 13:41:37 -xmr-pr- 7349 7663 7664 7665 7666 7667 7668 7670 7677 7678 7680 7681 7682 7685 7695 13:52:12 .merge+ 7686 7687 7688 7689 7690 7691 7694 7696 7697 13:52:12 Added 19:12:20 Any more feedback on https://github.com/monero-project/monero/pull/7692 ? 19:12:29 else I will add it to merge list 19:12:40 or maybe wait a bit longer as it is a larger change 19:14:36 I'd say, not as large as having mixed many ideas into one PR, but still manageable. 19:15:06 And it's about time Epee finally gets promoted to a shared lib. 19:15:23 mj-xmr: could you also approve 7693 ? :) 19:17:05 selsta, I somehow don't receive notifications on force pushes. Other than this, have you noticed, that 7693 has 3 commits? 19:17:35 yes, it is intentional 19:18:20 OK. If you know what you're doing :) 19:19:18 selsta, ticked. 19:19:24 thanks