CI fix, reviewed by selsta and erciccione: monero-project/monero #7172

will get merged with the next merge wave

selsta: Cool. Could you please explain me the wave strategy? Does it occur after stabilisation of every release? Or is it a bad time right now because you're busy firefighting?

.merges

^ we have a list, fighting the attack has priority currently, yes

I can't help with that yet unfortunately. Maybe some other time once I have a closer look. But thanks.

No problem, I’m mostly managing that. Once something is ready it gets on the list. Larger changes might wait longer.

Why are you here? For the tech? Then you should be off at Zcash instead of trying to con newbies into a coin that doesn't work.

For the money? If you put your money in BTC or ETH you would have been better off.

For the magical crypto friends? Monero leadership laughs from loosers like that. Find yourself more healthy realationships that don't steal your money.

Mates, here's the HTML report with all the currently ready tools in a historical manner. I will be publishing some documentation about it soon. enjo.hopto.org/pub/monero

It will be updated daily.

*inverse chronological manner I meant.

👍

why -"-rpc-restricted-bind-ip" option is not referenced in monerodocs.org/interacting/monerod-reference ?

Presumably because nobody sent a patch to whoever this is.

What's a patch and how do I send one?

Oh you meant that monerodocs.org/interacting/monerod-reference isn't even owned by yall, its owned by someone else

Yes, not ours. A patch is a file describing a change with a particular syntax. Widely used to coordinate changes across people.

afa12354, that was a relatively recent development, this rpc restric thing causing this behavior you may be experiencing. please contact the authots of monerodocs to fix

Would there be any interest in a gRPC API for the wallet?

What would be the use for it ?

And would you be maintaining it to follow changes in the current RPC ?

From wikipedia, that sounds like something up vtnerd's alley. Though he's into 0mq for the daemon.

gingeropolous, what behavior you are assuming it causes me? it doesn't cause any behavior except monerod gives me a "W --public-node is enabled, but RPC server mylocalip:18089 may be unreachable from outside, please check RPC server bind address" warning if --rpc-restricted-bind-ip isn't set to 0.0.0.0

Allows for pub/sub + synchronous calls. Has codegen built in for many langs and uses protobuf for serialization.

<moneromooo "And would you be maintaining it "> Hadn't considered that, started working on the implementation for the wallet rpcs and walletnotify, will keep it in mind if I make a PR.

ah ok. other folks ran into some troubles with bindings from this recent change. sounds like what u described.

afa12354, ^, but still the docs should be updated :)

vtnerd: ^

gingeropolous, what port do you reccomend for "--rpc-restricted-bind-port" option, is 18089 fine?Also I suppose the warning I get is a bug, because 0.0.0.0 includes the 127.0.0.1 IP and my desktop pc assigned IP in DHCP list on router settings?

should probably switch to #monero

Another question re gRPC, it doesn't support an auth mechanism natively, would this be a problem if merging?

.merge+ 7182

Added

.merge+ 7180 7181

Added

moneromooo: 7173 requires rpc minor bump

xiphon: please rebase 7161 (also don’t bump RPC)

Im not sure why yet another rpc system would be useful. would be nice to avoid protobufs, but theres a quasi dependency via trezor already

done

actually, recalling the protobuf spec, even 3 was kind of gross for server-side (when compared to something like msgpack for instance)

the two above were intended for virgildante[m]