02:07:07 .merge+ 7099 7086 02:07:07 Added 02:09:05 .merge+ 7098 02:09:05 ... 05:00:20 -xmr-pr- caozi522 opened issue #7171: The address created during synchronization is missing 05:00:20 -xmr-pr- > https://github.com/monero-project/monero/issues/7171 07:34:05 I've got something for your mind, your body and your soul: https://github.com/monero-project/monero/pull/7172 07:34:15 Hopefully this fixes the CI. 07:45:19 -xmr-pr- mj-xmr opened pull request #7172: apt update before installing 07:45:20 -xmr-pr- > https://github.com/monero-project/monero/pull/7172 09:18:00 Do you think that you are too smart to be in a cult? Then I would encourage you to look 09:25:28 Do you think that you are too smart to be in a cult? Then I would encourage you to look 09:25:28 into how any other cult works / worked. They aren't populated by stupid people. 09:25:29 Aum Shinrikyo was almost exclusively university professors and graduates. For Pete's sake - they had the know-how and means to make WMDs. 09:25:29 As to Monero, I would encourage you to look at Jonestown mass-suicide. You know why Jones killed them all? 09:25:30 Because he was afraid he is loosing control over them. People like that will burn everything to the ground around them rather than give up control. 09:25:30 Being smart doesn't make you immune to being in a cult. This is the most valuable lesson Monero taught me. 10:03:26 tvomme tries to push the XMR price down to buy more :) 12:03:39 tvonme: u r talking about psychopats...not so many here ;) 13:12:29 What do people think about killing the p2p public node system ? It seemed like a good idea at hte time, but it got us --no-sync and the list is just riddled with the usual polluters. 13:15:20 -xmr-pr- moneromooo-monero opened pull request #7173: restrict public node checks a little 13:15:20 -xmr-pr- > https://github.com/monero-project/monero/pull/7173 13:30:20 -xmr-pr- moneromooo-monero opened pull request #7176: protocol: do not reuse m_requested_objects 13:30:20 -xmr-pr- > https://github.com/monero-project/monero/pull/7176 13:30:20 -xmr-pr- moneromooo-monero opened pull request #7175: protocol: do not reuse m_requested_objects 13:30:20 -xmr-pr- > https://github.com/monero-project/monero/pull/7175 13:30:21 -xmr-pr- moneromooo-monero opened pull request #7174: restrict public node checks a little 13:30:21 -xmr-pr- > https://github.com/monero-project/monero/pull/7174 14:06:37 I'm not a big fan of the idea. Not having to look for a public node is a huge UX improvements IMO 14:07:52 Only for people who want to shoot themselves in the foot though. 14:08:19 I, OTOH, think everyone should run their own node. 15:08:54 I mean I guess it comes down to whether it can be made reliable or not 15:09:08 if it's reliable it's a great feature, if it's not it's not. 15:12:59 having both simple and bootstrap maybe seems a little redundant. what if simple mode were replaced by bootstrap+no sync? Then your logic for connecting to other nodes stays in the daemon and the GUI wallet doesn't have to deal with it. 15:13:45 the logic does stay in the daemon already 15:14:09 simple mode = --bootstrap-daemon-address auto --no-sync 15:14:19 I'm only going by the documentation but the guide I am looking at rn says simple mode does not run a local node 15:14:20 simple mode (bootstrap) = --bootstrap-daemon-address auto 15:14:42 perhaps the docs are dated https://github.com/monero-ecosystem/monero-GUI-guide/blob/master/monero-GUI-guide.md#about-the-simplebootstrap-mode 15:14:44 it runs a local node, you just don’t download the blockchain 15:14:55 ok I believe you, I'm just saying that's not what the docs say 15:25:00 Lyza: The guide is a bit outdated probably, yes. I haven't much time to take care of it at the moment. Could you open an issue on the repo? 15:25:03 hello, what will be fixed or what are the improvements for 17.1.8? 15:27:49 sure thing 15:28:04 thanks 21:14:25 Moneromooo are you here? I've got a question about this commit: https://github.com/monero-project/monero/commit/2899379791b7542e4eb920b5d9d58cf232806937#diff-eb68bc70cb6aeb0af3d4d6ebb9cfc2512547dc8590ae4b78f427dfe255b6e1c0 21:16:46 What is that question ? 21:23:33 It's about the execution path of a rpc_access_data json request. 21:25:28 I'm not the best programmer, so I'm going to try to explain. 21:26:16 I see in that code, only when the json rpc is called, as apposed to the cli, the json_rpc_request function is called. 21:27:08 I think it is intended for this code to run: https://github.com/monero-project/monero/blob/43f91ee12ec9cd539e011b7b551d66659fb3188a/src/rpc/core_rpc_server.cpp#L3197 21:27:29 But in practice, I don't think it can ever be called. 21:28:03 The logic for rpc payments requires that the rpc server be started in restricted mode. 21:28:53 But, rpc_access_data is an rpc call that is restricted itself: https://github.com/monero-project/monero/blob/43f91ee12ec9cd539e011b7b551d66659fb3188a/src/rpc/core_rpc_server.h#L184 21:29:18 So there is no way in which the previously mentioned code path can ever run. 21:30:44 I think you're correct. 21:33:53 Is there a reason we can't have rpc_access_data, be unrestricted? 21:34:37 The call itself, shouldn't allow people to modify their own balance, only view everyone's balance. 21:35:01 It would reveal client ID's to the world, but I don't think that is a security issue. Correct me if I'm wrong. 21:38:55 It's none of the business of anyone else, really. 21:40:02 It should be able to be run on the restricted port, to read what's on the other one. But atm IIRC two servers are started, rather than a server listening on two ports. So that should be changed first. 21:50:11 Ok, I hadn't realized there was that option. 21:50:29 I just tried using --rpc-restricted-bind-port 21:51:44 I first tied a jsonrpc call using sync_info i tried the restricted-bind-port, I got method not found as expected. 21:52:31 Then I tried the same jsonrpc call for the unrestricted port 28081 in this case, and I was able to receive data back. 21:53:26 I repated the same process for 'rpc_access_data', but I'm getting an error for the unrestricted port 28081. error code: 0 21:54:11 When I said "It should be able to be run on the restricted port" I meant "ideally it should be..." 21:54:31 ie, for it to work properly, there should be either one single server for the two ports, or some data sharing. 21:54:39 This is not currently the case. 21:55:15 ok, do you mind if I document this and the conversation in github issues? 21:55:29 Feel free. 22:15:20 -xmr-pr- t-900-a opened issue #7178: Make rpc_access_data method accessible via json rpc 22:15:20 -xmr-pr- > https://github.com/monero-project/monero/issues/7178