-
selsta
Kronovestan: added, the other ones, you sure about 104.243.35.17 ?
-
selsta
it is not DigitalOcean / OVH, which is normally used
-
selsta
also FYI, increasing out peers also increases the chance of connecting to an attacker node
-
selsta
added 104.243.35.17 too
-
selsta
.merges
-
xmr-pr
6495 7123 7124 7127 7128 7130 7131
-
selsta
^ would be ready for merges + v0.17.1.7 tag
-
selsta
luigi1111w: looks good to tag
-
luigi1111w
done
-
Kronovestan
selsta, appears the attacker is using another host I think
-
selsta
Got a second report about the IP so I added it
-
cvg8
the .7 tag is used to test or publish,without having to wait for 7135?
-
selsta
7135 requires the majority of nodes to run 7130
-
selsta
so we can’t include it in .7, also it is still work in progress
-
scoobybejesus
-
selsta
Kronovestan: did you just see 104.243.35.17 getting blocked, or did you see it reporting +2 using sync_info?
-
selsta
it also got auto banned from my nodes, so not clear what they did. will keep it on the block list I guess, they can reach out if it was a mistake
-
rbrunner
I am testing .7 as tagged a few hours ago, but I am a little out of the loop: Do recognized-as-bad peers get listed if I use the interactive "bans" command?
-
selsta
They have to get kicked a couple times before they are banned.
-
selsta
They will show up with "bans" command.
-
rbrunner
Alright, thanks. How to best watch the "kicking" then? Is there a special log category to best use?
-
selsta
It will display it
-
rbrunner
With the standard log level 0 already then, right? Ok. Then I guess it's just all quiet on that front right now, my daemon is sitting there silently, with over 70 out peers.
-
M5M400
selsta | 7135 requires the majority of nodes to run 7130 <- is that wise? given that a certain someone is spinning up nodes on da daily basis?
-
selsta
not sure if I follow
-
selsta
we will make this necessary after the next network upgrade
-
M5M400
ah
-
sech1
selsta but why is 7131 in the release branch merged when 7130 is not merged?
-
selsta
?
-
sech1
It's supposed to be included in the next network upgrade, not in 0.17.1.7
-
selsta
7135 will be mandatory in the next network upgrade
-
selsta
both 7130 and 7131 are merged, not sure what you mean exactly
-
sech1
looked in the wrong place ¯\_(ツ)_/¯
-
sech1
Is it safe to add more data to the existing network messages? Will .7 nodes communicate normally with .6 nodes?
-
selsta
yes
-
selsta
I have been running it fine
-
selsta
it will just get ignored
-
selsta
and once we include 7135 in a release (and the majority on nodes updated) it should be possible to run with --early-pow-sanity-check
-
selsta
scoobybejesus: my hashes match
-
Kronovestan
selsta, I had seen 104.243.35.17 in my sync_info
-
selsta
everyone doing reproducible builds, please upload the hashes to gitian.sigs so that we can release v0.17.1.7 later today :)
-
xmr-pr
codesoap opened pull request #7137: readline_buffer: Avoid consecutive duplicates in the history
-
xmr-pr
-
iDunk
-
xmr-pr
moneromooo-monero opened pull request #7139: Optional DNS based blocklist
-
xmr-pr
-
xmr-pr
moneromooo-monero opened pull request #7138: Optional DNS based blocklist
-
xmr-pr
-
Lyza
so, trying to do my deterministic builds this morning
-
Lyza
-
tevador
I've been running v0.17.1.7 for a couple hours with over 150 peers and my banlist is still empty. Is that expected?
-
Lyza
I think the issue might be these 404 not found messages when downloading packages:
pastebin.com/raw/xTM950s5
-
Lyza
I'm guessing it worked for others because they already had the packages cached
-
selsta
Lyza: which command did you use?
-
Lyza
selsta: ./gitian-build.py -j 3 --memory 3584 --detach-sign --no-commit --docker --build $GH_USER $VERSION
-
selsta
what did you set $VERSION ?
-
Lyza
v0.17.1.7
-
selsta
hmm, that could be the case
-
selsta
we updated qt a while ago but looks like we only updated it in master branch
-
selsta
so it could be possible that we have it cached
-
rbrunner
I am running .7 for six hours now, with 200 out peers, with only a single ban, which makes me think: I as an attacker would stop attacks until .7 is out; otherwise we could test too easy
-
selsta
do they get detected and kicked correctly?
-
rbrunner
With my daemon? Nothing gets kicked, as it seems - I have no messages at all in console output, except for that single stray ban
-
selsta
there is no message when a peer gets kicked
-
selsta
in log level 0
-
selsta
the test is to run without ban list and check status / sync_info if the +2 attack is working
-
rbrunner
Alright, so we misunderstood each other a few ours ago. Is there a way to modify log categories to see the kicks?
-
selsta
I misread probably. Kicking shows up in log level 1, bans in log level 0
-
selsta
It is easy for the attacker to add some rate limiting, e.g. only get kicked twice per IP.
-
rbrunner
Yeah, but too many other things show up with log level 1 :) I don't use the ban list, btw, and I am fully synced for those 6 hours
-
selsta
We can tune this for the next release. Some things don’t happen by accident / slow network, so for some things it should be possible to ban instantly and not after a couple times.
-
Lyza
selsta should I open an issue on the build process then?
-
selsta
Lyza: will open a PR
-
selsta
./gitian-build.py -j 3 --memory 3584 --detach-sign --no-commit --docker --url
github.com/selsta/monero --build $GH_USER qt-release
-
selsta
Lyza: can you check if ^ builds for you?
-
selsta
this will not be reproducible, but just curious if the error goes away
-
xmr-pr
selsta opened pull request #7140: [release-v0.17] Depends: Bump qt to 5.15.1
-
xmr-pr
-
rbrunner
Got it: With "set_log +net.cn:INFO" in the daemon console you can see a red line logged if a daemon is dropped because it claims a wrong height
-
rbrunner
I have a lot such lines, so the bad nodes are active after all
-
rbrunner
Somehow ... satisfying to see them dropped so easily now.
-
selsta
for now :)
-
sech1
for now (with evil voice)
-
rbrunner
I found 2 numbers I grabbed at random from the log lines in "block.txt"
-
rbrunner
for now (with evil voice and fading echo ... echo ... echo ...)
-
selsta
with v0.17.1.8 and DNS based block list the issue should be mostly mitigated even if he still finds edge cases to exploit
-
sech1
so next attack will be on DNS to block all legit nodes, right?
-
rbrunner
Shouldn't be as easy as renting cloud servers and seed them with doctored Monero daemons, one would think
-
sech1
At least it's optional to use DNS list. I don't want another centralization point.
-
Lyza
selsta that command gives me "error: pathspec 'qt-release' did not match any file(s) known to git."
-
selsta
you might have to do the first command step too
-
selsta
./gitian-build.py --setup $GH_USER $VERSION
-
selsta
add --url and replace version with qt-release
-
Lyza
-
selsta
you have to add --url like in the previous comment
-
selsta
-
Lyza
damn I missed that part
-
Lyza
-
Lyza
selsta *
-
Lyza
first step appears to go okay, but tells me it needs to reboot. second step fails both before & after reboot
-
iDunk
Use a different folder. md ../test && cd ../test && ./gitian-build.py --setup --docker --url
github.com/selsta/monero Lyza qt-release
-
iDunk
s/md/mkdir/
-
mfoolb
I'm seeing lot of difference in peers from a 17.1.7 synced node.. could that be public nodes updating after new version?
-
mfoolb
I meant difference in height
-
selsta
mfoolb: how do you see this?
-
mfoolb
sync_info
-
selsta
post the output
-
selsta
to paste.debian.net or so
-
mfoolb
-
selsta
looks fine, afaik it can take a bit until the height of peers update
-
mfoolb
ok.. I have some problem with gitian build
-
mfoolb
Could not download some packages, please run gbuild --upgrade
-
iDunk
Do you not recognize your problem in the conversation above ?
-
mfoolb
iDunk: talking to me?
-
iDunk
Yes. Same resolution.
-
mfoolb
selsta: after 15m this one is still locked at low height 75.139.205.63:18080 d7f83402f7990756 normal 0 2249685 0 kB/s, 0 blocks / 0 MB queued
-
mfoolb
iDunk: got to check the logs then..
-
selsta
Could be a node running in --no-sync. As long as the node is not lying about its height it is fine.
-
mfoolb
selsta: ok, thanks
-
mfoolb
-
iDunk
I think it is.
-
mfoolb
./gitian-build.py --setup --docker $GH_USER $VERSION <-- this is the setup for docket I found there
-
iDunk
Have you read the backlog and what selsta said ?
-
mfoolb
-
selsta
running with --url will result in the wrong hashes. though it should still compile
-
mfoolb
selsta: running without --url is not working.. It's me doing something wrong? Should it build?
-
selsta
One of the sources seems offline
-
selsta
it worked for those that still had it cached
-
mfoolb
ok thanks
-
selsta
Should be fixed in the next version
-
iDunk
Maybe we should skip right to .8 with 7140 if gitian is unbuildable for newcomers.
-
selsta
I already spent multiple hours doing GUI builds :/ Would prefer not.
-
selsta
If hyc also does builds we would have ti
-
selsta
them confirmed by 4 people
-
iDunk
I'll PR hashes soon.
-
hyc
what's up?
-
mfoolb
qttools-opensource-src-5.7.1.tar.gz receive a 404 while preparing for gitian build
-
hyc
ugh
-
hyc
as I mentioned before, we ought to just be creating a frozen docker image of all the dependencies instead of downloading all of them at build time
-
mfoolb
yes, I read you before and I humbly agree
-
moneromooo
If you pull all your deps from what the monero team prepared for you, if opens the door to the monero team to supply crafted deps. That doesn't happen if you pull from the OS' package repo.
-
hyc
you can still sha256sum the image
-
mfoolb
but you can't build if OS' repo don't know or don't want to check availability of needed packages
-
moneromooo
Does the original repo still have the hash, just not the actual package ?
-
hyc
my last build failed because linux-image-generic was unavailable
-
hyc
which is a stupid reason to fail in the first place
-
hyc
I commented out the repo check to get past that
-
iDunk
It's a source tarball that's been removed.
-
hyc
but being at the mercy of these repo prociders is ... fragile
-
hyc
providers
-
mfoolb
moneromooo: No package and no hash in the md5sums.txt file on repo
-
moneromooo
And does building with the new OS packages get you the exact same resulting monero binaries ?
-
» moneromooo guessing "it depends"
-
iDunk
OS packages have nothing to do with this.
-
iDunk
A tarball is missing somewhere on the internet.
-
moneromooo
Surely it depends what the tarball is for. ie, if it's gcc and the new gcc happens to have a new optimizer.
-
moneromooo
Anyway, it's not like I biuld those so I'll leave those who do decide :)
-
xmr-pr
moneromooo-monero opened pull request #7142: daemon: the ban command can now load IPs from a file (ban @filename)
-
xmr-pr
-
xmr-pr
moneromooo-monero opened pull request #7141: daemon: the ban command can now load IPs from a file (ban @filename)
-
xmr-pr
-
moneromooo
let
-
Lyza
nice
-
iDunk
moneromooo: If you can see pastebin :54:26 < Lyza> I think the issue might be these 404 not found messages when downloading packages:
pastebin.com/raw/xTM950s5
-
mfoolb
-
moneromooo
Sure, GCC was an extreme example to make the point.
-
moneromooo
I guess it would work if the people building and PRing signatures don't use the prepared deps.
-
iDunk
Anway, "Obimooo Kenobi: Merge them in pairs, Luke!"
-
hyc
perhaps we should be getting qtbase from code.qt.io or its github mirror instead
-
hyc
why were we using some random site in Brazil in the first place?
-
hyc
Oh I see, 5.7.1 is too old, it got removed from code.qt.io
-
mfoolb
and from the random brazilian site too :)
-
hyc
why don't we update to a recent version?
-
moneromooo
selsta just did.
-
iDunk
5.15.1 is already in master, but release PR was never done.
-
hyc
ok
-
iDunk
Until toda.
-
iDunk
y
-
hyc
-
moneromooo
yoda ?
-
hyc
I just downloaded the github copy, hash doesn't match the one we're using
-
selsta
the github source is auto generated by github
-
selsta
source archive
-
hyc
right
-
selsta
-
selsta
oh :) didn't read backlog
-
hyc
ok, so updated qt needs to go into next release and then no problem
-
Lyza
selsta okay I got about as far as last time but it still says it can't get some of the packages. the only specific package download error I see is
paste.debian.net/plain/1176744
-
hyc
huh haven't seen that before. I guess the set of trusted root certs is out of date
-
Lyza
FF doesn't throw any warnings about the cert so, yeah maybe
-
hyc
LOL their server cert has a typo
-
hyc
C = US, postalCode = 27514, ST = North Carolina, L = Chapel HIll, street = 153A Country Club Road, O = University of North Carolina at Chapel Hill, OU = nformation Technology Services, CN = distro.ibiblio.org
-
hyc
OU = nformation Technology Services - missing first "I"
-
Lyza
oopsie
-
sech1
"L = Chapel HIll" capital I
-
sech1
found it there :D
-
Lyza
lol
-
hyc
lol
-
hyc
the issuer cert that's missing is InCommon
-
hyc
-
hyc
will try downloading it from that link
-
sethsimmons
So is .7 supposed to fix +2 issue natively without ban-list, or .8, or neither? Have several people waiting on a non-ban list fix I’d like to keep in the loop, as well as update my blog post.
-
sethsimmons
I’ll comb through the PRs since I released that and see what is important to add as mitigations unless someone has a list handy as well.
-
hyc
Lyza: yes, if you grab the Incommon cert that was linked from that Stanford page, curl will work
-
hyc
but it has to be installed into the docker image each time, how annoying
-
moneromooo
.7 should fix it for a short time.
-
Lyza
thx hyc
-
sethsimmons
-
sethsimmons
This is great context, thanks selsta
-
sethsimmons
<moneromooo ".7 should fix it for a short tim"> Great! But still recommend ban-list?
-
hyc
Lyza: you can bypass this problem by manually downloading the file yourself
-
hyc
move it into ~gitianuser/builder/cache/common
-
hyc
put the sha256sum output into ~gitianuser/builder/cache/common/download-stamps
-
Lyza
I did try that hyc and it was still complaining about not being able to get something, though I dind't see any more errors. let me try again
-
Lyza
I was able to add the cert to my base system but Ig it needs to be added to the docker image and I'm not sure about how to do that one
-
hyc
using .stamp_fetched_xxxxx
-
Lyza
ahhh I didn't put the sha256 anywhere okay
-
hyc
look at the other ,stamp_fetched* files in download-stamps
-
hyc
.stamp_fetched...
-
hyc
should be .stamp_fetched-native_cdrkit-cdrkit-1.1.11.tar.bz2.hash
-
Lyza
*fingers crossed*
-
Lyza
well, I might be doing something wrong but I double checked the file names and locations and all and I keep getting the same error
-
Lyza
prolly about all the patience I have for it for now but thx y'all for the help
-
hyc
-
moneromooo
sethsimmons: yes, or the DNS blocklist in 7139 if auto update is required.
-
moneromooo
I will maintain that one, selsta will maintain the file one. So you can choose whose list you like :)
-
netrik182[m]
why were we using some random site in Brazil in the first place? <-- not completely random. USP is the biggest Uni in SA but still
-
xmr-pr
moneromooo-monero opened pull request #7146: p2p: remove peers from grey and anchors lists when blocked
-
xmr-pr
-
xmr-pr
moneromooo-monero opened pull request #7145: p2p: remove peers from grey and anchors lists when blocked
-
xmr-pr
-
xmr-pr
moneromooo-monero opened pull request #7144: p2p: ignore incoming peer list entries when we have them blocked
-
xmr-pr
-
xmr-pr
moneromooo-monero opened pull request #7143: p2p: ignore incoming peer list entries when we have them blocked
-
xmr-pr