.merges

Merge queue empty

hmm I remember adding things to it but I can’t find it in the logs...

.merge+ 6947 6956 6977 6989 7003

Added

vtnerd: please rebase 7009 (not urgent)

luigi1111w: sorry, there is a typo here: github.com/monero-project/monero/releases/tag/v0.17.1.6

replace with the following sentence

if you’re using the --rpc-restricted-bind-port option along with --rpc-bind-ip currently you will need to add the new --rpc-restricted-bind-ip arg or else the daemon will bind restricted RPC only to localhost.

Sorry 😢

Got the syntax mixed up

np

TheCharlatan: monero-project/monero #7103

Please what causes The I2P OUT connections all disconnected in a matter of minutes?

i am using i2p java(not zero)

do you have --anonymous-inbound?

It is possible that we have too aggressive timeouts for I2P, Tor seems to work a bit better

yes i have. but no INC , I think it's because NAT?

[P2P2] ERROR net contrib/epee/include/net/abstract_tcp_server2.inl:1576 [sock 173] Failed to start connection, connections_count = 795

is this likely due to some file limit or something variable in the system?

Latest version without blocklist +2 issue is still to me

cvg8 check your log and see if it's blocking any nodes. It might take a while until it blocks all malicious nodes one by one.

ok 51.79.58.90 , 51.68.209.38 it's gone takes a few minutes

yes, they're both in the block list

I would still keep using gui.xmr.pm/files/block.txt

ok ,thanks

They are known malicious nodes, better to block them right away

sech1, what can do a bad node?

a lot of things, from spying on transactions to disrupting the network

ragn4: it can NOT put your funds at risk (but might stop you from spending them), it can not reveal the destination address, or the amount.

then those nodes are from the nsa?

or just the bytecoin devs jaja

can anyone point me at a simple monero task I can do to get started?

a beginner friendly bug

or feature enhancement. I know c++, java, js well

monero-project/monero #7012 maybe

moneromooo: thank you. I will explore it. btw could I get paid by doing something like that?

Unlikely.

For some larger body of work though, there's a CCS (ccs.getmonero.org) which can provide funding,

:(

I doubt I have that much time. I just wanted to pitch in when I had some time.

The CLI can transact with the +2 blockheight problem. Feather wallet can also do it. But the GUI wallet cannot. I thought that was an oversight that was going to be fixed in *.1.6 but apparently not? Is there a reason to keep the GUI this way?

"Is there a reason to keep the GUI this way?" -> is the daemon issue, should be fixed on the monerod side

Lyza: I submitted a patch, it did not make it in

xiphon I mean I don't disagree that it should be fixed in the daemon as well but what's the reasoning for the CLI and GUI to behave differently here? I don't get it.

tobtoht_ do you have a link?

Lyza: monero-project/monero #7066

thanks

Ig I sort of get it but consistent behavior between official wallets does still seem desirable *shrug*

both CLI and GUI use the same libwallet codebase

CLI uses wallet2 directly

so? the other is just a wrapper around wallet2

the issue is inside the wrapper

ugh. then the wrapper is not just a wrapper any more, and that was a mistake.

all of this should start over and both CLI and GUI should just be frontends to wallet-rpc

having diverging code in the official source tree like this is ... sloppy

hyc: would be feasible once wallet-rpc opens its interface _before_ it starts the wallet refresh

now you have to wait an indefinite amount of time before you can any information from the wallet

sounds like that should be fixable

.merge+ 7106 7107

Added

.merge+ 7009

Added

Prove that you really have the most critical thinking community. Come to t.me/get_monero and let's discuss things like adults.

2020-12-10 15:53:19.937 [RPC0] ERROR net.http contrib/epee/include/net/http_protocol_handler.inl:318 [IP:port INC] simple_http_connection_handler::handle_char_out: Error state!!!

im seriously thinking of just grepping my logs for ERROR, then extracting the IP and then blocking via firewall

i think IP is always bracketed like [IP:port IN/OUT] right? should make for easy cut parsing

Yes.

huh. this error state shows up when i legitimately try to connect to a remote node from the GUI

aaand now the gui won't close :(

it should close if you wait long enough, it tries to exit cleanly, else just force quit it

[RPC1] ERROR net.http contrib/epee/include/net/http_protocol_handler.inl:387 [IP:PORT INC] simple_http_connection_handler<t_connection_context>::handle_invoke_query_line(): Failed to match first line:

yeah, so thats from a legitimate attempt from my GUI to access the node

ah well, there goes that idea

gingeropolous: monero-project/monero #7081 might be interesting for you

?

fluffypony: do you know about monero-project/monero #7077 for sure ?

yes it's the root

you can see the query order there

ty

.merge+ 7116 7115 7102 7106 7107 7108 7109 7110 7111 7104 7104 7100 7101 7117 7118

that’s a lot of PRs...

7106 7108 7110 would benefit from a second look

.merge+ 7105 7103

Added

luigi1111w: please merge 7108 7109 early so that we can avoid merge conflict

done

thx

moneromooo: please rebase 7110 7111

done

.merges

.merge- 6989

Removed

So — the +2 height issue is completely disabling all BTCPayServer Monero users ATM, it appears

Anyone running that is getting fed the false block-height and unable to sync because of it.

Is there any other fix except the ban-list? Apparently they use a custom Docker Monero image that doesn’t allow easily adding in the ban-list.

I’ve had two separate merchants reach out to me on Twitter about this, as we were hoping v0.17.1.6 would resolve this in some way.

hmm, both CLI and RPC should not have issues

but I don’t know what BTCPayServer does exactly

Yeah me either TBH

It must use the same wrapper as the GUI if it’s still having the issue on v0.17.1.6

.merge+ 7114 7120 7121 7122

Added

.merges

luigi1111w: not sure how available you are, but it would be great if you could merge these and tag v0.17.1.7

if you have less time I can write you the release-v0.17 PRs list specifically