-
dEBRUYNE
-
moneromooo
There's no check a tx relay was successful. But if you add net.p2p.msg to the log categories (log level 1 is enough to include it), you should see when a tx is relayed to a peer.
-
dEBRUYNE
ty
-
fluffypony
-
selsta
I tested this yesterday, only monero related warnings are `Multiplication result may overflow 'int' before it is converted to 'unsigned long'.` a couple times
-
selsta
so most likely not worth it to activate for monero
-
selsta
-
moneromooo
Where ?
-
moneromooo
And if it is not spammy, it's probably worth having.
-
selsta
src/wallet/wallet2.cpp#L852 src/wallet/wallet2.cpp#L850 src/wallet/wallet2.cpp#L824 src/wallet/wallet2.cpp#L875
-
moneromooo
ty
-
moneromooo
We don't care about those indeed.
-
moneromooo
Would it spam about those for every PR ?
-
selsta
I don’t know yet, I think it would only display warnings for new code
-
selsta
we can enable it and disable it again if it is annoying
-
xiphon
^ or just fix three lines
-
selsta
there are 30 results overall but most are in external libraries or it complains about "localtime" or "gmtime"
-
xiphon
gotcha
-
selsta
will have to read the docs a bit more, apparently you can customize what kind of warnings you want
-
moneromooo
Would be nice to have a monero coverity account again. It found actual bugs, occasionally.
-
selsta
I can create one, or should core team do this?
-
moneromooo
Core team would be better. If you go bye bye, we'll still have it.
-
selsta
I can create one and then give instructions to luigi :P
-
selsta
for creating a core one
-
gingeropolous
does the daemon challenge a potential peer? like, ask for some random old block?
-
gingeropolous
im thinking of those nodes out there that just repeat the max height value
-
moneromooo
No.
-
gingeropolous
though i guess it eventually drops the peer if it doesn't prove any useful data
-
moneromooo
That seems like a good idea offhand, but I don't recall why this wasn't done before.
-
gingeropolous
i mean, its some bandwidth and processing overhead
-
moneromooo
Ah, because it's mostly annoying for new people who want to sync, and those don't have history, I think.
-
moneromooo
So still a good idea.
-
gingeropolous
yeah, if your a fresh sync, its not gonna help yah
-
moneromooo
Unless someone can think of a drawback (bandwidth/processing is really not much hre, we'd ask for a tx)
-
xiphon
why not just drop a useless peer?
-
gingeropolous
but there should be a way to tie in checkpoints? well an attacker could incorporate the checkpoints
-
moneromooo
Because you might not be useless to it.
-
moneromooo
You could drop on a timer if it's useless to you and hasn't requested some data in a couple minutes.
-
moneromooo
I had a patch for this IIRC.
-
xiphon
yep, that looks better than challenging it
-
gingeropolous
i mean, so whats the flow. My node: "hi, what height are you, im looking to sync. I have x block height. What is your blockheight?"
-
moneromooo
Except if it's not well tuned, you might end up dropping slow peers.
-
xiphon
^ yep, even if we'll use 30m timeout, we'll eventually drop the *bad guys*
-
xiphon
huh and the next iteration will be like: bad guys periodically request some data from us
-
gingeropolous
attacker peer: "i have x block height too! You should connect"
-
gingeropolous
my peer connects, doesn't get any new data.
-
gingeropolous
and now this attacker peer is effectively sybilling me cause it costs them nothing to prop up these mirrors
-
xiphon
i see no way to completely mitigate sybilling atm
-
xiphon
on the other hand some heuristic could definitely be added
-
xiphon
for example, if the peer reports X height and requests block at < X height, that's is not okay
-
gingeropolous
well the peer wouldn't request a block at x height.
-
gingeropolous
xiphon, yeah, you can't completely mitigate sybilling with a permissionless network, but you can make it costly
-
gingeropolous
i wonder if you could packet-ize data transfer between p2p. because evne if there's some heuristic or blockchain checking, a peer could just request that info from an honest peer
-
gingeropolous
however, if you make it so the monero p2p protocol only sends data in chunks of n Mb, it will again make the bad peer use more resources... but also the resources of the honest peer its leeching from.... but still
-
Snipa
.merges
-
xmr-pr
Merge queue empty
-
selsta
if you are bored gui always has merges :P
-
Snipa
Yeah, I saw, that's why I was checking.