-
moneromooo
.merges?
-
moneromooo
.merges
-
xmr-pr
6812 6813
-
moneromooo
Can someone review 6815 please ? It would be nice to get in 0.17, it's a fix for pre-rct txes failing to create.
-
moneromooo
.merge+ 6745
-
xmr-pr
Added
-
dsc_
moneromooo: rubber stamped
-
moneromooo
Thank you
-
fluffypony
-
fluffypony
interesting read on ARM
-
TheCharlatan
I ran a check on the contents of the merge commits after I read about sia silently introducing controversial changes.
-
TheCharlatan
If found the following merge commits containing extra changes: 1f6e6001ed37b48788ef071f3297b7e9d67586a5 e69849e97911a6543759aabf9feccd865445337f 77224bbf4842f3c7fb53ad7685f45cf768f5ec38 7223eebbe71833e895fca95267cb243834dedf83
-
TheCharlatan
All seems in order with them, they contain some submodule and vendored dependency changes.
-
moneromooo
git show 1f6e6001ed37b48788ef071f3297b7e9d67586a5 doesn't show any diff. How do you get a diff ?
-
TheCharlatan
^ does for me.
-
TheCharlatan
-
moneromooo
What git version ?
-
TheCharlatan
2.17.1
-
moneromooo
Do you get different output than
paste.debian.net/hidden/256af446 ?
-
moneromooo
Or do you use particular git options ?
-
moneromooo
Should we bump the max out connections a bit, now that traffic has been cut a fair bit ?
-
selsta
I have latest git version (2.28.0) and get the same output, no diff
-
selsta
bump to 12-16?
-
selsta
.merges
-
xmr-pr
6745 6812 6813
-
selsta
.merge+ 6815
-
xmr-pr
Added
-
TheCharlatan
ah, my script was still showing commits with two parents. Looks like they are all clean then :)
-
pyu
!
-
selsta
TheCharlatan: what do you mean with descriptor .yml files in /gitian?
-
NHnCH3
latest master "release-static" building failed?
-
vv01f
can you pint me to the "official URI spec"? I just found the function in the client/API and the fandom wiki… which seems not sufficient.
-
moneromooo
NHnCH3: IIRC I used the "fandom wiki" to write the wallet source.
-
moneromooo
er, vv01f ^
-
moneromooo
What in particular seems not sufficient ?
-
vv01f
k, just wanted the taler guys to add monero for RFC 8905
-
vv01f
so I will point him to the source then with the note that the wiki was the definition.
-
moneromooo
NHnCH3: you can check github, there's a bot building all PRs. Not sure if t's building static though. It should say in the logs.
-
TheCharlatan
-
selsta
TheCharlatan: thx updated
-
vv01f
moneromooo: is there any direct contact address for them (Christian Grothoff) to reach out to you? (in your github account I cant find any)
-
moneromooo
No.
-
moneromooo
They're welcome to ask here though.
-
vv01f
k, will mention that one.
-
vv01f
where to publish a payto-URI specification (payto://monero/ according to the RFC) for registering the respective payment target type in the GANA registry?
-
moneromooo
Discussing this here or in a github issue seems best.
-
vv01f
so that monero community can give its ok beforehand and publish it as a spec.
-
moneromooo
Probably github since it'll likely be long lived.
-
vv01f
would you think it's worth the ffort to include monero early on in that?
-
moneromooo
I don't know, not knowing what this is about, etc.
-
moneromooo
Opening a github issue would be a good way to ascertain it.
-
vv01f
the GNU Taler devs want to spec the handling of general payment URI officially and with that backing also encourage institutions to adopt
-
vv01f
their way is specs first in general, same for PEP etc.
-
vv01f
thanks for now, will have a look on github later on.
-
NHnCH3
thanks moo
-
vv01f
moneromooo: added
monero-project/monero #6817 and looking forward to comments
-
moneromooo
ty
-
luigi1111w
.merges
-
xmr-pr
6745 6812 6813 6815
-
selsta
6819 and then branch?
-
selsta
.merge+ 6793 6819
-
xmr-pr
Added
-
» moneromooo has no objection
-
selsta
6816 too?
-
selsta
does not matter I guess
-
selsta
.merge+ 6816
-
xmr-pr
Added
-
selsta
.merges
-
xmr-pr
6745 6793 6816 6819
-
selsta
6745 needs a rebase now
-
moneromooo
Oh, sorry, slipped my mind. Rebasing now.
-
» moneromooo 's alerts triggered
-
moneromooo
Latest commit on master is not signed
-
moneromooo
luigi1111w: did you push 9bba1a24eadbc7d23a5a58d83024df224f9cafcb ?
-
moneromooo
Or was it worked by someone after you did...
-
moneromooo
Looks like my exact code. Thankfully a small patch.
-
moneromooo
Odd. It says monermooo-monero. Missing o. Might be why it didn't get signed if it got modified after signing.
-
moneromooo
Could be a test run. Modify something innocuous, see if it gets found.
-
» moneromooo looks around for occam's razor
-
moneromooo
pushed
-
TheCharlatan
weird mistake with the name. please blink luigi.
-
selsta
moneromooo: does 6745 need a minor rpc bump?
-
moneromooo
Oh yes, it does touch RPC a bit... I'll add.
-
moneromooo
done
-
selsta
luigi1111: please merge the merge list + branch release-v0.17 whenever you have time
-
moneromooo
6820 is another patch to make merge mining easier. Also comes with the same conflict of interest note as the previous one.
-
moneromooo
This one's teeny tiny though.
-
moneromooo
It will save verification hashing time on whoever's merge mining.