-
moneromooo
selsta: 6785
-
selsta
moneromooo: thx, does this also address the multisig issue or is that separate?
-
moneromooo
No.
-
moneromooo
Separate.
-
moneromooo
The obvious candidate is not the culprit, so bisect time.
-
moneromooo
Thanks tridge for bisect.
-
xmr-pr
moneromooo-monero opened pull request #6785: core_tests: fix failures after v13
-
xmr-pr
-
sarang
^ fixes the test CI?
-
grydz
-
selsta
sarang: minor rpc bump seems gone after rebase
-
xmr-pr
grydz opened pull request #6786: Fix protocol with Ledger's HW when using CLSAG
-
xmr-pr
-
moneromooo
selsta: 6787
-
moneromooo
sarang: ^
-
xmr-pr
moneromooo-monero opened pull request #6787: ringct: fix CLSAG serialization after boost/epee changes
-
xmr-pr
-
sarang
moneromooo: looks like 6787 still fails CI testing?
-
sarang
selsta: sigh, not sure how that RPC stuff got lost in the rebase...
-
sarang
but I'll wait until the CI gets sorted out... don't want to get failing code merged
-
selsta
6787 + 6785 is required for passing CI
-
sarang
Ah, I see
-
sarang
Shall I wait until those are merged and rebase then?
-
sarang
^ selsta moneromooo etc.
-
moneromooo
Oh hai.
-
sarang
heh
-
sarang
Wondering the desired order for PRs/rebases
-
moneromooo
If this is regarding the new PRs, selsa is correct. Two different problems, two patches.
-
sarang
to cause the fewest headaches
-
sarang
sure
-
moneromooo
I think the fixes will not conflict with anything else.
-
moneromooo
If they're reviewed soon, they can get merged soon too.
-
sarang
So what's the desired path forward for these PRs relative to 6600?
-
moneromooo
I'd be fine with any order, as they're unrelated really.
-
moneromooo
If you review the fixes, I can add them to the bot now.
-
moneromooo
They're short patches.
-
moneromooo
OK, the first one's not *that* short, but conceptually simple.
-
sarang
wilco
-
sarang
done
-
moneromooo
ty
-
moneromooo
.merge+ 6785 6787
-
xmr-pr
Added
-
sarang
:D
-
hyc
now if only we had a bot to write the fixes and MRs for us
-
sarang
OK, when those are merged, I'll rebase 6600 and add the RPC stuff... not sure what the heck happened to that change
-
xmr-pr
moneromooo-monero opened pull request #6788: Made spelling, grammar, and punctuation changes. Squashed commits int…
-
xmr-pr
-
dEBRUYNE
^ Thanks
-
dEBRUYNE
.merges
-
xmr-pr
6600 6693 6785 6787
-
sarang
6788 looks good
-
sarang
reviewed
-
selsta
.merge- 6600 6693
-
xmr-pr
Removed
-
selsta
(will be added later)
-
selsta
.merges
-
xmr-pr
6785 6787
-
luigi1111w
.merges
-
xmr-pr
6785 6787
-
sarang
6600 rebased with RPC version updated
-
sarang
pending CI...