-
selsta
luigi1111w: please also merge
monero-project/supercop #4
-
vtnerd
selsta: ... the macOS/darwin depends build on travis is finally compiling with the amd64 asm :)
-
azunda
@rehrar
youtube.com/watch?v=ILB3GmBAP7k - still not working, when rewinding video switches to different. It's not because yt encoding.
-
azunda
please fix it ;)
-
moneromooo
.merge+ 6354
-
xmr-pr
Added
-
selsta
moneromooo: could you add all existing approved PRs to the merge bot that we want to include in the next HF?
-
selsta
if we can do one round of merges it should be easier to have an overview of what is left to review
-
Snipa
.merges
-
xmr-pr
6354 6500 6542 6546 6593
-
Snipa
For 6500 - Is this still ready to be merged? The last discussion seems to have trailed off without any finality. 6542, 6546, 6593 need some friendly eyeballs. :)
-
moneromooo
I'd say yes. Someone can add some sed later to convert version variants.
-
selsta
vtnerd: thanks for fixing, looks like we can include it in next release :)
-
moneromooo
There's still the AS/ASM mismatch.
-
moneromooo
Oh there's a comment sauing that'll be dropped. Good.
-
vtnerd
it wasn't a mismatch, the gnu assembler is called "as"
-
hyc
it's actually called gas. as was the original AT&T assembler for Unix
-
moneromooo
Hmm. Sounds odd, but OK.
-
moneromooo
I'm talking about the varaible, just to make it clear.
-
iDunk
I was wondering about that too.
-
moneromooo
It's cmake though, so it might made to annoy people.
-
caralho
cmake is best make
-
moneromooo
^ someone who only knows cmake and libtool
-
iDunk
With the latest changes, gcc (set by CMAKE_ASM_COMPILER) seems to be the asm compilere of choice.
-
caralho
clang is only for the most 1337 hackers
-
hyc
since clang was developed largely with Apple's assistance, I inherently dislike it
-
hyc
gawd, every time I see one of our stack traces I want to puke
-
moneromooo
Why ? They don't resolve addresses to symbols ?
-
moneromooo
Or just because they exist ? :)
-
hyc
those function signatures are atrocious
-
hyc
and largely noise
-
moneromooo
Oh you mean gdb, not the ones we log... right.
-
hyc
such a stark difference between a C trace and a C++ trace
-
hyc
the C trace shows the actual values of parameters
-
hyc
it's actually useful
-
hyc
the C++ trace shows you class inheritance, but no parameter values
-
hyc
and our class heirarchy is just gross
-
moneromooo
I think this can do too if you build with enough -g and little enough -O.
-
hyc
e.g. the gdb.txt that was just attached to issue #6744
-
hyc
thread 14 backtrace - pure noise
-
hyc
thread 14 frame 14 - this is insane
-
moneromooo
Ah, but you can use less -SR, the spam gets clipped and you see the good stuff :)
-
hyc
hmm, that's a bit more readable, but the fact is that C++ is still pushing all this garbage around in the actual code
-
hyc
how many pointers does it have to dereference to find one method being invoked
-
caralho
less is more
-
Inge-
Why is ther even a class hierarchy?
-
hyc
That's an excellent question
-
moneromooo
.merge+ 6329
-
xmr-pr
Added
-
moneromooo
.merge+ 6493
-
xmr-pr
Added
-
moneromooo
.merge+ 6600
-
xmr-pr
Added
-
moneromooo
.merge+ 6601
-
xmr-pr
Added
-
moneromooo
.merge+ 6618 6632 6634 6661 6662 6677 6679 6689 6691 6693 6698 6703 6712 6715 6716 6718 6720 6722 6727 6736
-
xmr-pr
Added