GUI bug that I might submit later to github but am leaving here in case I forget

If you try to send an amount that exceeds the existing balance from account A, and then switch to account B (with sufficient funds), the 'amount exceeds unlocked balance' warning (and locked send button) persist until the amount is modified

Switching to the Send tab should cause a refresh

dEBRUYNE: yes the spend proof just requires your private address keys; it sounds like the reddit guy wants to make an OutProof, which is only possible with the tx private key

moneromooo: is there a way for miners to manipulate the "already_generated_coins" amount when contracting miner tx in "construct_miner_tx"?

*constructing

and is already_generated_coins the total coins minted after or before the mined block

in blockchain.h, one comment says already_generated_coins is "the total coins minted after that block" and while another one says "the amount of currency generated prior to this block"

You can pass an override to the function, and use that if set.

Presumably before the block is mined. I would have to see hte code to make sure.

But it increases after each block, so both are technically true :)

Hi

CLI v0.16.0.3 binaries are up on getmonero.org. Thanks a lot to everyone contributing their build hashes, and selsta in particular for driving this

And all contributors etc of course :)

Awesome, all nodes migrated to 16.0.3 without flaw :)

what are key new stuff?

DoS fixes and other bug fixes/minor changes

hello

hey; moneromooo, that patched wallet your sent yesterday, where does it put the logs?

monero-wallet-cli.log, same directory as the binary.

And does he need to run it at a specific log-level?

yes, --log-level 0

moneromooo: can you take a look at monero-project/supercop #4 ?

done

okay luigi1111 please also merge ^ later when you do merges

moneromooo - here is the log from the affected user

KnifeOfPi: from which height did they restore?

It does not have my patch.

It also logs extraneous stuff. Looks like it's not other changes in.

And if it is the case, I'm not going to debug further :)

it's got*

That patch didn't apply here.

The second one.

that’s the branch I compiled

That seems right.

KnifeOfPi: can you double check if they selected the correct monero-wallet-cli ?

yes

iDunk: can you check if this one has the patch applied? gui.xmr.pm/files/cli/cake-issue-tmp

he claims he used the right one

I guess you can run strings on it and grep for "process_new_transaction"

Or upload it to some file sharing host and I will.

it does have process_new_transaction in it

so the binary is 100% correct

Maybe he sent the wrong log then.

For example: ERROR wallet.wallet2 src/wallet/wallet2.cpp:2501 start_height=2166876,curre

2105 just has "else" in selsta's branch.

2501

yep, definitely wrong log or wrong .exe selected

here is screenshot from the user

KnifeOfPi: the log you sent is 73kb, the one on the screenshot 103kb

huh... i'll ask him again

he is insisting it's shrinking after he sends the log...

Makes sense, since it's removing my new logs and inserting those unknown logs instead.

That said, it could technically be true, windows inserts extra \r characters on newlines. 73/103 seems way too much though.

I will test that branch now and look if the logs look like expected