-
scoobybejesus
So we're breaking tradition and not re-tagging? Nice. :P Mine appear to be the same:
paste.debian.net/1159128
-
luigi1111
first time for everything
-
xmr-pr
zhouqiang-cl opened issue #6742: Using Chaos Engineering to enhance monero
-
xmr-pr
-
xmr-pr
yzn5555 opened issue #6743: xmr节点生成新的地址耗时5分钟
-
xmr-pr
-
fluffypony
-
fluffypony
is there anyone that reads and writes Chinese?
-
Inge-
@realsexycyborg :P
-
Inge-
there is also the monerocn TG group
-
fluffypony
lol
-
moneromooo
re-tagging ? Did the .3 replace an existing tag ?
-
hyc
-
iDunk
I don't think it did. There is no .2 in my gitian out dir.
-
moneromooo
Good :)
-
moneromooo
TheCharl1: are you TheCharlatan ?
-
moneromooo
If so, mind commenting on
monero-project/monero #6337, the last tweak to which removes an addition you made to fix cross compilation ?
-
moneromooo
It apparently breaks something for vtnerd.
-
selsta
-
sethsimmons
I'll kick off my build now
-
sethsimmons
I'll stop mining for a bit 🥲
-
sethsimmons
I think I had to ask this before and have forgotten the fix -- running into an isssue getting packages for the gitian build: `Unable to connect to 172.17.0.1:3142`
-
selsta
wasn’t it firewall related?
-
iDunk
IIRC, it was the firewall last time.
-
sethsimmons
ah I'll double check
-
sethsimmons
yup fixed with `sudo ufw allow 3142/tcp`
-
sethsimmons
Forgot I rebuilt fw since the last tagged release
-
sethsimmons
Thanks!
-
xmr-pr
LordSquigles opened issue #6744: [P2P8] ERROR default src/common/threadpool.cpp:118 wait should ha...
-
xmr-pr
-
moneromooo
monero-project/monero #6745 is the unlock time change I'd like to have for the fork.
-
selsta
ok
-
selsta
soo CLSAG + this need a review
-
selsta
moneromooo: would you also like
monero-project/monero #6616 ?
-
moneromooo
If it gets reviewed, sure.
-
moneromooo
It's not a must have though.
-
xmr-pr
moneromooo-monero opened pull request #6745: Use recent block times for unlock time
-
xmr-pr
-
Snipa
.merges
-
xmr-pr
6418 6500 6536 6538 6542 6546 6565 6571 6593
-
Snipa
Looks like the bot's a bit shot. 6536/6538 are both merged already
-
Snipa
As is 6565
-
dsc_
Snipa: Could you issue a .merges once more?
-
Snipa
.merges
-
xmr-pr
6418 6500 6536 6538 6542 6546 6565 6571 6593
-
Snipa
I've just merged 6571 and 6418
-
dsc_
yep okay, thanks
-
sethsimmons
Linux hashes match for gitian builds
-
sethsimmons
Do we want a Reddit thread for the hashes/gitian for this tag?
-
sethsimmons
I can create it cloning an old one if someone can tell me the main features/fixes in 16.0.3
-
moneromooo
DoS fixes.
-
sethsimmons
Thanks
-
sethsimmons
Is there a specific PR I can link to for that moneromooo
-
sethsimmons
-
moneromooo
6728
-
sethsimmons
Great, thanks.
-
sethsimmons
-
caralho
6536
-
sethsimmons
Was that a response to me caralho
-
caralho
nope, sry. Testing something out
-
sethsimmons
ah ok, thanks :)
-
dsc_
xmr-pr got rate limited by github, the bot will return later today
-
dsc_
I've put him in the naughty corner.
-
sethsimmons
Android/FreeBSD also match so far
-
sethsimmons
Ran into an error building windows:
paste.centos.org/view/1a15e3e7
-
iDunk
Looks like OOM killer.
-
scoobybejesus
How many cores and how much memory?
-
binaryFate
Could anyone who wants to confirm the hashes for v0.16.0.3 CLI please commit to the gitian repo?
-
iDunk
I build with -j5 and m12000.
-
sethsimmons
16c/32t
-
sethsimmons
Did -j32
-
iDunk
lol
-
sethsimmons
Should I change to -j16?
-
asymptotically
sethsimmons: how much ram have you got?
-
sethsimmons
32G
-
sethsimmons
But Monerod and a few other things are running and eating some RAM
-
asymptotically
-j24 works for me with 32g
-
sethsimmons
I'll try with that
-
sethsimmons
I've built fine with -j32 in the past
-
sethsimmons
But might be hitting a cap slightly now
-
asymptotically
i think that the problem is just with linking. the llvm cmake scripts let you limit the max number of link jobs running at once. not sure how it works but maybe we can steal it? :D
-
asymptotically
or tell make that some of the bigger files need to be run alone
-
sethsimmons
No idea how to change those
-
sethsimmons
Restarting all builds with -j16 instead
-
sethsimmons
wish me luck
-
iDunk
You don't have to build everything from the start.
-
iDunk
Just add -owm if Win and Mac builds are the only ones left.
-
sethsimmons
How do I skip certain builds/only run Windows?
-
sethsimmons
Comment out other platforms from gitian-build.py?
-
iDunk
No
-
iDunk
Insert -ow in your command if you only want to build for Windows.
-
sethsimmons
-owm for windows and mac?
-
sethsimmons
Mac had yet to run
-
iDunk
Yes
-
sethsimmons
nice that worked, thanks
-
sethsimmons
any recommendations for the `--memory` flag?
-
sethsimmons
Set it to 12000 at some point but could probably be refined
-
sethsimmons
ThreadRipper 1950X 16c/32t w/ 32GB RAM
-
iDunk
Use as much as you can spare, I guess.
-
iDunk
I use -m12000 as I can spare ~12GB out of 16 GB on that machine.
-
sethsimmons
sweet, thanks.
-
hyc
I never specify the memory flag
-
hyc
just lt it use as much as there is
-
hyc
of course, my laptop has 32GB RAM and 8 cores. 4GB per build thread is enough, so far
-
hyc
we really need to reign in all this header file madness
-
moneromooo
Someone did show up a couple months ago promising large gains in that area.
-
hyc
all those templates in the epee networking code are just totally unnecessary
-
moneromooo
There was a CCS for it.
-
hyc
yeah, I remember seeing that
-
moneromooo
I suspect it was overeager promises but decided to waut and see :)
-
hyc
frankly it galls me to see people come in out of nowhere and demand money before they pitch in and help
-
hyc
they should just stick to working for commercial software companies if that's their attitude
-
selsta
they did some contributions FWIW
-
selsta
ccache stuff
-
moneromooo
That's a weird one. I've been using ccache for years without any change.
-
hyc
I don't see anywhere ccache can help in this project
-
moneromooo
My sanity.
-
hyc
if you touch a header file and force a recompile, that's unavoidable
-
hyc
if you don't touch any header files, make already does the minimal required work
-
moneromooo
It still helps a lot. Changing defines for example. ccache also caches preprocessed source.
-
hyc
ccache is just superfluous. even more ludicrous, it's part of the gitian builds
-
moneromooo
And when you rebase and change branches. Oh boy does it help.
-
hyc
even though gitian spins up a fresh docker image for every build
-
caralho
thats hyperbole
-
hyc
there is nothing cacheable/reusable
-
moneromooo
It's definitely not superfluous. I love ccache ^_^
-
hyc
for gitian, it's useless. completely.
-
moneromooo
Well, if is in a fresh fs, sure. But that doens't mean it's superfluous. Just superflous in this partiuclar case.
-
moneromooo
But it's mostly irrelevant since it can be used without anything changing in monero anyway.
-
moneromooo
If I didn't have ccache, I'd probably have loads of "fixup this shit" commits :/
-
hyc
that would improve the codebase
-
moneromooo
:|
-
hyc
time for you to drop ccache from yout path for a while :P
-
moneromooo
I meant I would not squash them into the relevant earlier commit.
-
hyc
ohh
-
hyc
I thought you meant you would stop and fix all the annoying slowdowns as you encounter them
-
moneromooo
Ah. Well, I did that too a year or two back.
-
moneromooo
The dude who did hte ccache patch seemed to have more experience than me with this though.
-
hyc
I don't change branches much these days. I just have multiple worktrees from a single repo, one for each branch I'm working on
-
xmr-pr
00-matt opened pull request #6747: cmake: Use job pool feature to limit concurrent jobs
-
xmr-pr
-
xmr-pr
jagerman opened pull request #6746: Fix broken multisig pubkey sorting
-
xmr-pr
-
binaryFate
People who help with reproducible builds: please make a PR to the gitian repo. It provides a hash *signed* with your key (unlike confirming on IRC or reddit). And gives public auditability of the hashes confirmations.
-
sethsimmons
I don't have PGP setup... Need to do that first.
-
moneromooo
(and makes monero-update see and use it)
-
binaryFate
It's ok to post hashes on IRC/reddit only (without signed PR), but I cannot rely only on that. That is not what users will expect me to have checked.
-
binaryFate
I need enough people to make the effort to PR to gitian, which provides PGP-signed vetting from them (not just their IRC account saying something) and auditability in the future on why I decided that sign off on certain hashes.
-
binaryFate
*to
-
sethsimmons
I'll work on getting mine setup over the next couple of days when I have time.
-
sethsimmons
Thanks for the push.
-
binaryFate
Right now I'm asked to sign something because selsta plus 3 people on IRC confirmed it. Apart from a small epsilon, it's basically the same as trusting selsta only. IRC is not PGP.
-
caralho
seems legit
-
hyc
-
iDunk
Another set of sigs from a person on IRC is up.
-
selsta
.merges
-
xmr-pr
6500 6542 6546 6593
-
TheCharlatan
bit late again with my build, but will have sigs up soon and then merge.
-
selsta
TheCharlatan: did you see moos message?
-
TheCharlatan
The one asking if me is me?
-
moneromooo
-
moneromooo
Yes.
-
selsta
14:17 <+moneromooo> If so, mind commenting on
monero-project/monero #6337, the last tweak to which removes an addition you made to fix cross compilation ?
-
iDunk
Btw, I tested with set(CMAKE_SYSTEM_PROCESSOR ${CMAKE_HOST_SYSTEM_PROCESSOR} CACHE STRING "" FORCE) today.
-
TheCharlatan
moneromooo do you mean the patch that iDunk commented?
-
moneromooo
Yes, I did.
-
selsta
-
selsta
not iDunk’s patch
-
TheCharlatan
Ah, I see
-
binaryFate
<hyc> added my sigs
monero-project/gitian.sigs #61 <-- thanks hyc and iDunk
-
moneromooo
I meant the line vtnerd removed, but iDunk found a way to fix it since then.
-
iDunk
Windows builds would not use supercop code anyway, with that (UNIX AND...) bit.
-
iDunk
The benchmark with supercop code segfaults on Windows, from either MSYS2 or depends builds.