-
xmr-pr
xiphon opened pull request #6715: wallet2: throw a error on wallet initialization failure
-
xmr-pr
-
xmr-pr
xiphon opened pull request #6716: wallet2_api: implement runtime proxy configuration
-
xmr-pr
-
ErCiccione[m]
Could somebody post the logs of yesterday's meeting on getmonero?
-
sarang
I heard back about the impact of the proposed upgrade schedule on Ledger integration
-
sarang
and am told that the integration of CLSAG into their application can't be done by September 17, but may be done by October 17
-
sarang
and that no one else on the Ledger team can work on the Monero application at the moment
-
hyc
I don't suppose their app is open source?
-
dEBRUYNE
It is
-
hyc
so if necessary, someone else could write the update
-
dEBRUYNE
-
sarang
It is, and I'm writing back to ask if the relevant branch containing CLSAG work is posted anywhere
-
dEBRUYNE
sarang: Honestly, I find that answer a bit frustrating
-
hyc
so end users can build it and install it themselves?
-
sarang
I need clarification, since my understanding was the necessary changes are already done, and just need to be rebased/merged at the appropriate time
-
dEBRUYNE
The company has boatloads of funding, yet no one can supposedly work on an important upgrade for one of the more popular coins
-
dEBRUYNE
hyc: Yes, but needs to be compiled, which is a PITA
-
sarang
Anyway, I'll ask for further clarification
-
sarang
I assume that there would not be consensus to delay the proposed timeline?
-
hyc
I don't see a problem with October. the last hardfork was November1 wasn't it?
-
dEBRUYNE
Accomodating plenty of time for third-party wallets to upgrade is one thing, having to postpone it for a few months because one provider cannot work on it is another
-
hyc
with PoW changeover on Nov 30
-
sarang
I mean only because it's now unknown if Ledger would be ready
-
dEBRUYNE
hyc: Release was Nov 1 afaik and actual fork date Nov 30
-
hyc
yeah that's what I meant
-
hyc
so another release on Nov 1 seems fine to me
-
dEBRUYNE
But last year we kind of had to postpone stuff because we weren't ready
-
dEBRUYNE
As far as I can see, we (+ the ecosystem) can be ready in two months, give or take
-
sethsimmons
Personally, if Ledger can't be ready with a huge heads up/runway, we push ahead with clear messaging on why ledger support is lacking at HF
-
sethsimmons
Very clearly mentioning it in all messaging about the release, as well as providing estimates on the Ledger-support update afterwards.
-
sethsimmons
And just make it abundantly clear that we gave them a huge heads up but they weren't able to meet it, not that Monero itself failed to integrate it etc.
-
dEBRUYNE
I don't see that as an option either to be honest
-
hyc
all that's going to do is irritate everyone. what's the benefit of an approach like that?
-
ErCiccione[m]
We already set teh date keeping in consideration that they needed more time. I'm strongly against moving the date up because of ledger. I agree with dEBRUYNE
-
dEBRUYNE
There will be tons of support requests every day as well as frustrated users
-
sarang
I'll ask what the _earliest_ possible schedule could be in order to guarantee support
-
sethsimmons
Then do we just delay until every wallet has full support on all network upgrades?
-
sarang
without promising that there will be support for such a schedule
-
sethsimmons
Seems like a slippery slope IMO
-
hyc
we only have trezor and ledger to worry about at the moment
-
hyc
is trezor ready to go already?
-
dEBRUYNE
hyc: MyMonero too
-
dEBRUYNE
They have to make changes for CLSAG afaik
-
dEBRUYNE
sethsimmons: I was more thinking of assisting Ledger with some stuff so we can move the timeline up
-
sethsimmons
Probably Cake and Monerujo as well
-
hyc
don't they just use monero's libs?
-
sethsimmons
<dEBRUYNE "sethsimmons: I was more thinking"> If this is possible, absolutely
-
dEBRUYNE
Cake and Monerujo use the GUI lib basically
-
sethsimmons
Ok, good to know
-
ErCiccione[m]
trezor said to let them know the height and they will be good
-
sethsimmons
I don't mean that we shouldn't try to do everything we can to get Ledger ready in time, but rather if that fails, do we delay the network upgrade until whenever they choose to/are ready to release?
-
sarang
Trezor will have a small PR to the Monero codebase when we merge the CLSAG code and decide the height, I am told
-
sarang
But they made it sound like they are otherwise good to go
-
sarang
and apparently they've already been doing testing with their own test suite
-
ErCiccione[m]
At the end if they don't care of moving Monero up on their priorities, people will just go to the competing company that will do it, as it should be. We can give ledger as much support as they need, but adapting to the needs of a company which makes money on Monero is absurd.
-
hyc
sethsimmons: I just mean, here we are in July, and they're telling us October.
-
ErCiccione[m]
should be their priority not ours
-
hyc
if they miss their promised October date, *then* we rake them over the coals
-
hyc
but for now, they've given us advance warning. what's the problem?
-
sethsimmons
Thats what I'm saying
-
sarang
I am asking the following things of the Ledger team now (the head of the coin integration team is now looped in on the emails)...
-
sethsimmons
Not to move UP the date, but to keep the date we set yesterday, try to help them how we can, and be clear about the lack of support if they aren't ready
-
sarang
1. Will any additional changes to the Monero codebase be needed (aside from
SarangNoether/monero 91e77ce) for Ledger support?
-
sarang
2. Is the new Monero app for Ledger (that includes WIP CLSAG support) available? If nobody else at Ledger can/will be able to work on it, perhaps someone else will if it's made available.
-
sarang
What is the earliest possible schedule (code freeze, binary release, upgrade) that could guarantee Ledger support? There seems to be a fair amount of developer frustration that Ledger support could be unavailable given the currently-proposed timeline, especially given all the earlier work that had been done on CLSAG Ledger integration.
-
sarang
^ that's question 3
-
sarang
[end questions]
-
sethsimmons
Thats great
-
sarang
Seem reasonable? I'm trying to communicate the frustration in a constructive way, and offer possible solutions
-
hyc
looks good
-
sarang
Hopefully having the team lead in the loop will help to get more specific answers about timing
-
sarang
After this is all done, I'll make a much better effort to understand the hardware wallet development cycle
-
sarang
and avoid these kinds of scheduling problems in the future
-
hyc
sounds like the prblems happen on their side
-
sarang
If there were another developer who could work on the application, that might solve it
-
ErCiccione[m]
The problem is only on their side. I don't understand why we should bend to the needs of a company who cannot make a schedule to accomodate the needs of their customers
-
sarang
This may be primarily a case of bad timing, where the sole developer is unavailable
-
sarang
I don't want to throw anyone under the bus here
-
sarang
I'm operating on my clearly incomplete understanding of their broader development cycle
-
ErCiccione[m]
I feel like we are trying to solve somebody elses problems
-
sarang
It sounds like with a slightly different schedule, there may not be an issue
-
sarang
I'll wait to hear back on that
-
dEBRUYNE
sarang: As far as I know, there are multiple people that have sufficient capabilities to work on XMR
-
sarang
Within the Ledger team?
-
sarang
Or more broadly
-
sarang
If their working branch is made available, maybe someone else can finish it up
-
dEBRUYNE
Yes
-
dEBRUYNE
At least cslashm and the person that took over
-
sarang
The person who took over is the person unavailable
-
sarang
And cslashm handed over responsibility already
-
ErCiccione[m]
My solution: 1) Announce the date and warn people that ledger might not be ready for the hard fork 2) wait for ledger's customer to complain 3) Ledger realize its paying customers are pissed if they cannot use tehir hw 4) ledger gets its shit together. Profit
-
sarang
Perhaps wait until I hear back from the team lead
-
sarang
If only a small schedule change would be needed, that'd be great
-
sarang
Not ideal, but great for users
-
dEBRUYNE
ErCiccione[m]: That sounds like a mutually destructive course of action
-
ErCiccione[m]
I think it's a bad idea. We already set a date keeping in consideration their internal problems (because that's what it is). It's simply a wrong approach IMO.
-
dEBRUYNE
It will only sour the relation with Ledger
-
dEBRUYNE
sarang: Yes, but afaik he still works at ledger
-
dEBRUYNE
I don't see why he cannot jump in
-
dEBRUYNE
This is basically an 'emergency' case
-
sarang
Part of setting a date was to see if it would be reasonable for those teams, no?
-
ErCiccione[m]
What are you referring to?
-
dEBRUYNE
The strategy you outlined
-
dEBRUYNE
It will merely result in pissed off users, a pissed off Ledger team, and a soured relationship between Monero and Ledger
-
ErCiccione[m]
oh, that wasn't really serious :)
-
ErCiccione[m]
but i stand by my point that adapting too much to the needs of a company that makes money on Monero is wrong. Should be the other way round and also sets a bad precedent. Support as much as they need. Moving our schedule, no.
-
sarang
Well, the schedule was pretty arbitrary
-
sarang
Sticking with it simply on some kind of principle, if it harms users, seems unwise
-
sarang
At least having a candidate schedule has moved the discussion forward with Ledger
-
sarang
and there's some benefit to that
-
ErCiccione[m]
No. We are telling them that they do whatever they want, because we will adapt to "not harm users"
-
sarang
I see your argument, but I would at least like to wait and hear from the team lead
-
sarang
Perhaps the response will be "ok, we can make that work after all"
-
sarang
Perhaps not
-
ErCiccione[m]
I still think it's a wrong approach, but sure we can wait for their reply. The release date is set in the meantime.
-
sethsimmons
I think sarang has a good middle ground.
-
sethsimmons
We've set a date that we will do our best to stick to, and use to leverage Ledger to try and meet our generous timelines
-
sethsimmons
If they respond that they can't do it until some very late date, we have another discussion on what to do then
-
sethsimmons
But in the meantime we certainly owe them the chance to respond etc.
-
sethsimmons
The ideal is that they realize we mean business and they have no good reason to hold up our network upgrade, and they figure out how to not have an entire coin support rely on a single person and meet our dates
-
sethsimmons
If that doesn't happen we can move from there with more clarity.
-
ErCiccione[m]
I'll shut up after this, but we don't owe them anything. It's totally the other way round. Let's keep that in mind.
-
sethsimmons
We owe them common decency to communicate
-
sethsimmons
I don't think we owe them delaying the deployment because they have a single point of failure
-
sarang
OK, I reached out to cslashm again as well
-
sethsimmons
Thanks sarang
-
sethsimmons
For spearheading the comms around this
-
sarang
No problem; I want to make sure it's all handled in a civil way
-
ErCiccione[m]
sethsimmons: Sure, of course and since we care, we gave a generous timeline, we offerd support and we are even trying to fix their problems. I think that's where we should stop.
-
sethsimmons
I agree with you
-
sethsimmons
Just hoping it doesn't come to moving forward without support
-
sarang
So the status is that I've asked those questions of Francois (who now does the Monero development for Ledger) and the integration team lead, and also just looped in Cedric (who says he is quite busy but may be able to jump in with select tasks)
-
sethsimmons
So let'
-
sethsimmons
Is Cedric = cslashm?
-
dEBRUYNE
Yes
-
sethsimmons
Assuming so
-
sethsimmons
thanks
-
sarang
yes
-
sarang
OK, he's contacting Francois as well to get more clarity on this
-
selsta
kinda missed the discussions in the last days but we can’t announce a hard fork without Ledger support, though that seems to be consensus anyway
-
rbrunner
Personally I see it as much more complicated. Seems to me there is much confusion and diverging opinions how to best react to this difficult situation.
-
selsta
monero includes ledger source code so if Ledger updates later we have to release again anyway
-
selsta
and I’m not interested in doing 2 releases :P
-
rbrunner
Well, there wasn't exactly a dearth of point releases. That could well go into one of this, in a worst-case scenario that is. Hardfork would be only once of course.
-
rbrunner
I see the whole story as growing pains, which will only increase with success, with bigger "ecosystem", more players, more interdependencies. It's hard to stay capable of acting.
-
rbrunner
Nobody plans to make life hard for anybody else, but how to decide if push comes to shove. Very difficult questions.
-
moneromooo
There are people who do.
-
sech1
Knowing how software dev works in reasonably big companies... If if fork date is moved to November then December etc. someone will always ask for more time
-
sech1
*Even if
-
sech1
Just set a deadline for everyone once, and then help whoever asks for help
-
rbrunner
3 months out, not to forget
-
sarang
There is already ledger CLSAG code in the Monero branch