16:51:36 Is the xmrig dev here on irc? 16:55:14 xmrpow: no but he replies quickly to emails and github issues 17:09:33 xmrpow what's up? 17:10:56 you can create github issue or ask u/XMRig on reddit or ask me here 17:16:18 sech1: Problem already solved ;) 17:37:15 https://github.com/monero-project/monero/issues/6674 17:38:05 I don't think it's high priority issue, more of an what-if evaluation 17:41:51 pretty major change to ecosystem. basically all client/server/exhcnage software 17:42:01 nothing would be left untouched 17:43:12 the old format would still be supported, that's a no-brainer 17:43:25 irrelevant 17:43:41 if not enough sites support the new format, you can't use it when you want to 17:44:40 it has to be a forced upgrade, like a hardfork, but even more far-reaching 17:45:02 it could be a soft-fork 17:45:17 Uh, if I ever saw an uphill battle in cryptocurrencies, I think that would be it 17:46:01 fwiw I don't think it's worth it, but I spent enough time on it to warrant posting it 17:47:36 might as well adopt emoji encoding 17:47:53 more bits per character, shorter addresses 17:48:28 let’s see how that works for Tari 17:48:40 it’s probably appealing to the “younger” generation 17:48:42 frankly it would bug the shit out of me 17:49:04 that can't possibly work 17:49:06 is there OCR software for emoji? 17:49:13 tevador: why? 17:50:12 because □□□□□□□□□□□□□□□□□□□□□□□□ 17:51:25 Tari has emoji addresses with hex encoding as fallback 17:51:27 lol 17:51:47 hex, so only 4bits per character. quite lengthy 17:53:08 we should xmit addresses simply as a position, Nth digit of pi onward. 17:53:40 addresses could also be bitmaps, probably 32x32 would be enough 17:54:23 how do you type those in on a CLI? 17:55:36 [0,0] black, [0,1] white etc. 17:55:42 lol 17:55:48 no need to change address format 17:55:58 no one would write it down anyway 17:56:08 QR codes are irrelevant 17:56:14 decade from now some new tech will arise 17:56:57 for quick scanning like a QR code sure you could use an RGB bitmap 17:57:27 put a calibration stripe next to it 17:57:43 or... just use the actual QR code 17:57:53 which has built in ECC 17:58:01 QR codes are quite used in the ecosystem and I also added support for it in CLI :D 17:58:07 but not merged yet 17:59:43 would appreciate review of someone who is familiar with windows utf8 encoding: https://github.com/monero-project/monero/pull/6488 18:00:24 using ANSI block characters? 18:02:40 selsta why do you single out "L" in PRINT_UTF8? 18:02:51 hyc: unicode I think 18:02:58 it's a C++ standard for unicode strings, not like it's going to change at all 18:03:11 L"some unicode string" 18:03:40 I do cout on linux / mac and wcout on Windows 18:03:47 and wcout requires L afaik 18:03:58 why don't the others require L ? 18:04:24 Maybe do #define PRINT_UTF8(pre, x) std::wcout << L ## x 18:04:24 for Windows ??? 18:04:39 without pre 18:04:47 or macro concatenation doesn't work this way? 18:04:52 that won't work with std::endl 18:04:53 sech1: that wouldn’t work with endl 18:04:56 yea 18:05:45 I would also define macros for WTEXTON() WTEXTOFF() (no-ops on non-Win32) as well as WEOL() 18:05:51 and get rid of all the other inline ifdefs 18:06:17 ok 18:09:37 what’s the best way to do noop in C++? 18:09:49 seen multiple suggestions on Google 18:10:00 #define NOOP(x) 18:13:42 yeah just an empty #define 18:15:29 ty, updated the PR 18:19:44 #define NOOP(x) ((void)0) 18:20:00 Or #define NOOP(x) do {} while(0) 18:20:14 yea that’s what I have seen on Google, is there a reason to do this over just empty define? 18:20:15 Because you just want to add a ; at the end lexically. 18:20:41 The do while also helps with two if. 18:22:04 not needed in this use case 18:23:04 but yes, the do-while is needed if the macro may be in an if clause 18:26:50 ^ whenever you want the thing inside {} to behave as a single statement 18:28:18 not needed here, if (condition) ; is valid C++ 18:29:43 do { ... } while(0) is only needed if you want to put more than 1 statement in the macro