-
selsta
luigi1111w: cli merge list #6548, #6569, #6572, #6575, #6577
-
selsta
then you can tag :)
-
selsta
same for gui
-
selsta
thanks
-
Edmond_Dantes66
hey what resources should i use to get "up to speed" on how the code functions? Is there an index of sorts?\
-
moneromooo
git grep is good.
-
moneromooo
You want to know how "X" works, git grep X.
-
moneromooo
I started by finding little bits I wanted to change, grepped for these bits, found the code, read the ode, changed the code till it worked.
-
moneromooo
There's a "zero to monero" doc that explains the crypto parts.
-
moneromooo
Which I should go read I guess since the crypto's still eluding me.
-
moneromooo
git log's also very helpful. grep the commit messages, see changes.
-
hyc
I've stuck to just nuts and bolts. higher level purpose and meaning is out of my scope
-
Edmond_Dantes66
cool thanks! moneromooo
-
Edmond_Dantes66
@hyc might you explain a bit more
-
hyc
I mean, when I work on the code, it's to fix syntax and structural problems
-
hyc
all you need to know is C/C++ syntax and which relevant data structures are being used
-
hyc
you don't need to understand the meaning of the cryptographic functions being used
-
hyc
I only care that the functions are written correctly to do what they claim to do
-
Edmond_Dantes66
oh ok
-
hyc
It's nice to understand the math at a deeper level, just because learning more is good. but it's not always necessary, to be able to get useful work done on the code.
-
Edmond_Dantes66
yeah i got you. ive done c/c++ for a while so i might try doing that
-
UkoeHB_
Edmond_Dantes66: if you go for ztm, aim at the 2nd edition
-
jtgrassie
Edmond_Dantes66: it actually doesn't take long to familiarize yourself with the code. It's pretty well organized.
-
jtgrassie
As moneromooo says, grep is your friend. Then a decent editor that can jump around.
-
jtgrassie
e.g. vim and ctags.
-
jtgrassie
The less friendly part of the code is wallet2!
-
victorSN
tazmanian this old Monero paper also documents some crypto functions in section 4.1:
getmonero.org/resources/research-lab/pubs/MRL-0003.pdf
-
victorSN
If you ever return I hope you read it
-
dEBRUYNE
Seems like we can tag after 6575 is merged
-
fluffypony
I'm ready with DNS recs whenever
-
rbrunner
Wow, how did that finally happen :)
-
» dEBRUYNE will create a reddit thread for deterministic builds once the tag is set
-
fRit_^
hi, any idea how to fix it? depastedihrn3jtw.onion/show.php?md5=197d2effdf812e1b3d9a8afc579d58a3
-
DeanWeen
fRit_^ do you have SOCKSPort 127.0.0.1:9050 in your torrc ?
-
fRit_^
DeanWeen, yes
-
DeanWeen
is tor started?
-
fRit_^
DeanWeen, yes, netstat shows that .moderod goes trough 127.0.0.1:9050
-
fRit_^
DeanWeen, only trough 127.0.0.1:9050
-
DeanWeen
then the only other thing I would think is maybe the .onion:18080 you're trying to reach is not reachable
-
DeanWeen
either down or you cannot find a way to rendezvous
-
selsta
luigi1111w if you are still online I think you can tag now
-
luigi1111w
was hoping to hear something like that
-
selsta
and then also gui after doing remaining merges
-
luigi1111w
-
selsta
yay
-
hyc
nice
-
rehrar
Tagged and bagged.
-
dEBRUYNE
luigi1111w: Thanks for the tag
-
luigi1111w
nitrogen nebula is correct, yeah?
-
iDunk
Monero 'Carbon Chamaeleon' (v0.16.0.0-release)
-
selsta
:S
-
hyc
doh.... yeah Nitrogen Nebula
-
selsta
what would a release be without messing something up :P
-
scoobybejesus
shall i stop my docker build? :D
-
selsta
tag to v0.16.0.1 or force push the tag?
-
rbrunner
Haha that did not take long. Best release ever but getting the name wrong :)
-
selsta
-
selsta
luigi1111w: you can decide
-
hyc
I would just fix and force-push the tag
-
iDunk
Delete the tag.
-
dEBRUYNE
I'd force push, otherwise we will get a bunch of people asking where 0.16.0.0 is
-
hyc
yeah
-
luigi1111w
I'm confused
-
selsta
we forgot to change the name inside the source code
-
selsta
I didn’t even know that there was a name inside
-
luigi1111w
ok cuz I named it correctly, lol
-
selsta
yep
-
luigi1111w
pr please
-
selsta
-
rbrunner
Maybe we can spare that 0.16.0.1 for later. I mean, all the individual PR's look ok, but probably nobody had ran the *combination* for any length of time, to test, right?
-
moneromooo
I can't beleive it. We've kind of agreed that rewriting tags is bad, and first chance we get everyone votes to rewrite it.
-
hyc
has this existing tag had time to propagate anywhere? if not, what's the harm?
-
rbrunner
Yeah, it's about half an hour old ... give it some slack :)
-
luigi1111w
every release requires deleting tags
-
luigi1111w
if we don't have to, we missed something
-
hyc
lol
-
moneromooo
"No need to put the seatbelt on, I'm just going round the corner". But to proceed, I'll have my "I told you so" message as soon as someone pops in with a question about why his 0.16.0.0 source doesn't match the repo.
-
luigi1111w
get it ready
-
moneromooo
*do proceeed
-
luigi1111w
it's already replaced
-
hyc
we'll all do reproducible builds from the current tag, so anything older doesn't matter
-
dEBRUYNE
-
scoobybejesus
So far so good on the Linux docker-made bins?
paste.debian.net/1148178 If so, I'll post the whole thing to reddit when done
-
hyc
my build seems to be remaking all dependencies, so it'll be a while before I get any binaries
-
iDunk
I took care of that as soon as release-v0.16 was branched.
-
fort3hlulz
Is this strictly not supported for Ubuntu 20.04?
-
fort3hlulz
Tried running it but ran into issues with the setup step
-
fort3hlulz
using docker
-
iDunk
Different toolchain, different hashes.
-
iDunk
(If it works)
-
hyc
eh, inside the container it should all be ubuntu 18
-
hyc
shouldn't matter what the host is
-
iDunk
So the builder pulls an 18.04 image ? Cool.
-
hyc
yes
-
selsta
-
selsta
there are the steps I use on a Ubuntu 18.04 VPS
-
selsta
these*
-
selsta
hmm I should not pull the gitian script from master I guess
-
hyc
it hasn't changed recently so that's safe enough
-
selsta
ok
-
hyc
I don't think docker.io is in ubuntu repos now
-
hyc
I had to add a docker ppa to get it on my ubuntu 19 machine
-
selsta
tried these steps today and did not have problems
-
hyc
sure. for ubuntu 18
-
selsta
didn’t read your message properly
-
fort3hlulz
Thanks selsta I'll try that now!
-
selsta
scoobybejesus: my hashes match
-
scoobybejesus
sweet
-
fort3hlulz
-
fort3hlulz
I'm fairly new to Ubuntu, this is my first real time using it, I'm always using CentOS/RHEL for work
-
selsta
can you try again?
-
iDunk
ifconfig and see if you have a docker0 interface.
-
fort3hlulz
I do
-
fort3hlulz
docker0: flags=4099<UP,BROADCAST,MULTICAST> mtu 1500
-
fort3hlulz
inet 172.17.0.1 netmask 255.255.0.0 broadcast 172.17.255.255
-
scoobybejesus
do you have ufw running? could be blocking
-
iDunk
hyc: 3142 is thta apt-cache thing ?
-
fort3hlulz
I do have UFW running
-
fort3hlulz
I'll try allowing 3142 I guess?
-
iDunk
Allow port 3142 then
-
scoobybejesus
hyc and i went round and round a while back. ufw on the host was my problem. mine's not on a VPS so i just turned it off for this purpose lol
-
fort3hlulz
yup that worked :)
-
scoobybejesus
:)
-
fort3hlulz
ufw enable 3142/tcp fixed it
-
hyc
great
-
iDunk
-
selsta
iDunk: did you have the dependencies cached?
-
selsta
or what kind of machine do you have :D
-
iDunk
:20:54 < iDunk> I took care of that as soon as release-v0.16 was branched.
-
iDunk
:)
-
iDunk
Actually, when I made that version change PR for gitian.
-
selsta
Any opinion on self hosting a backup for depends packages?
-
selsta
Kinda like bitcoincore.org/depends-sources/ but for our packages.
-
hyc
may not be a bad idea. I'd prefer a single canonical source for packages
-
selsta
I guess there would be no legal problems anyway as the software is open source?
-
selsta
Apart from the macOS stuff.
-
hyc
usual apple fuckery
-
selsta
Well bitcoincore.org still hosts it :P looks like they don’t care
-
hyc
imo we should stop supporting Apple, as long as they pull this proprietary shit
-
hyc
my Linux hashes also agree scoobybejesus
-
fort3hlulz
This gitian build takes a long time 0.0 putting my 1950X to work :P
-
hyc
did you do the build step with -j <number of CPUs> ?
-
fort3hlulz
yeah I did -j$(nproc)
-
fort3hlulz
its maxing out my CPU at most points
-
hyc
good
-
fort3hlulz
all 32 threads
-
hyc
an idle core is a wasted core
-
selsta
can I do -j16 with 32GB RAM?
-
fort3hlulz
ALl my idle cores are usually crunching RandomX hashes ;) But today is a build day
-
hyc
selsta that should usually work
-
selsta
I set it to -j12 for now
-
hyc
there are a few files that may need 3GB, but you'd have to have bad luck to have a conflict there
-
hyc
I personally won't buy a machine now with less than 4GB RAM per core
-
fort3hlulz
I only have 2GB per core :( Need to double the ram in this box ASAP
-
fort3hlulz
Keep forgetting to, only have 32GB with this 1950X for now
-
hyc
(excluding my phone that is)
-
fort3hlulz
Linux hashes match iDunks
-
fort3hlulz
I'm doing it :D
-
fort3hlulz
I don't have a GPG key (I know, I know...) so should I just post the hashes on Reddit?
-
fort3hlulz
Or is there something else I should do to help validate?
-
hyc
go generate a key already
-
hyc
but yeah, go ahead and post on reddit
-
scoobybejesus
this bugs me though, since you can't restore your GPG key:
dev.gnupg.org/T169
-
fort3hlulz
I'll try and generate a key and sign this weekend, but for now I'll share all hashes on reddit/here
-
scoobybejesus
well, they merged the mnemonic restore issue with that one. still, it'd be great to have a restore mnemonic
-
fort3hlulz
-
fort3hlulz
Seem to match!
-
fort3hlulz
Hopping off for a bit now, but will try to get those GPG-signed sometime over the weekend as well.
-
fort3hlulz
Thanks for the help getting my first gitian builds going :)
-
selsta
:)