-
xnbya
moneromooo: I don't have a PoC, but 100 post v4 blocks are a problem
-
» moneromooo going to restrict some requests some more soon ^_^
-
moneromooo
vtnerd_: do you think utf8canonical should be changed for the boost code you pasted (in another patch) ?
-
moneromooo
Also, the "only works if log_filter returns codepoint equal or
-
moneromooo
" comment is just about buffer overflow, right ? No other reason ?
-
moneromooo
(ie, a copy on first longer would work)
-
moneromooo
What do people think of the "peer claims higher version, we might be forked" message ? Looks there's a neverending supply of cunts making this message useless now. Remove ?
-
moneromooo
Or move to info/debug.
-
selsta
I’d move it to info instead completely removing it
-
sarang
Can it realistically be used for any meaningful action by the user?
-
moneromooo
Yes: go to getmonero.org to see if they forgot to update for a fork.
-
sarang
But in the face of so much spam?
-
moneromooo
There might be a way to test for plausibility by asking for some PoW hashes and checking for diff...
-
moneromooo
Oh no. Now it's mostly pointless.
-
sarang
Yeah that's what I mean
-
» moneromooo takes it to debug
-
scoobybejesus
If you're taking requests :) , the "Last scheduled hardfork time suggests..." message could be made less frequent. Perhaps every 6, 8, or 12 hours, rather than every 2?
-
moneromooo
I removed this one. Though I kept the other one, not sure why. I'll remove it too.
-
selsta
I thought you removed it already
-
selsta
ah wait there are two
-
selsta
that’s what you meant
-
moneromooo
Yes, I did not remember/notice there was another.
-
selsta
should we remove unknown seed nodes from code?
-
selsta
(those that have been down for a while)
-
moneromooo
I have no objections since we have a few new ones now.
-
moneromooo
Might want to ping pony about the IPs.
-
selsta
we have 8 online 6 offline
-
selsta
those are apparently not fluffys
-
selsta
or he forgot about them :)
-
UkoeHB_
moneromooo: for some reason a bunch of your recent PRs have been doubled up (e.g. 6568/6569)
-
selsta
release-v0.16 and master branch
-
moneromooo
Looks fine to me. One is for master, the other for release-v0.16.
-
rbrunner
Is the current version of the 'utf8canonical' method already the "release candidate"? Can I test that again now?
-
rbrunner
Or you do wait for some more feedback from vtnerd in this, moneromooo? For my own stuff I would propose to make optimizations together with vtnerd only in the master PR, so the branch PR gets ready early
-
selsta
+1
-
moneromooo
I've made the changes I thought were worth it, I don't intend to change it again unless bug. All the other stuff can be done in another PR.
-
rbrunner
Alright, thanks. Will play with the method interactively a little more with the help of the MMS then. Alice in Chinese Hanzi and all :)
-
moneromooo
The only difference is tolower -> towlower IIRC.
-
rbrunner
Alright, I am through with my release PR.
-
rbrunner
The master PR will have to wait for the weekend, but I guess that does not matter :)
-
moneromooo
Any windows coder here ? There's a (presumably) easy patch that could be made, to detect FAT where the blockchain is and complain, since it will break for files > 4 GB.
-
xiphon
moneromooo: wll have a look
-
moneromooo
Thanks.
-
hyc
FAT16 as opposed to FAT32? who still uses FAT16?
-
moneromooo
No idea about the details of which variant is fine or not. I guess a Windows coder will know where to find that info :P
-
moneromooo
But there's been at least two reports of this on github. One just a few days ago.
-
moneromooo
OK, a month and a half. And it was FAT32. Maybe there are variants of FAT32 ?
monero-project/monero #6429, 6th April.
-
hyc
hmmmm
-
SerHack
lol FAT-16? It's really old ~Windows 2000
-
hyc
ah you're right, filesize limit on fat32 is 4GB
-
selsta
luigi1111w: can you merge 6551 tonight?
-
selsta
6532, 6540, 6541, 6543, 6545, 6554, 6560, 6562, 6567, 6569
-
selsta
^ these would also be nice to merge
-
selsta
then we need 1 more merge list tomorrow and then we can tag
-
vtnerd_
moneromooo : just noticed that easylogging doesn't include any boost headers, so dunno. I liked the separate encode/decode functions (more flexible/reusable) and the code could be copied
-
luigi1111w
selsta yes
-
vtnerd_
theres a few more checks for invalid utf8 encodings: (1) top two bits of every trailer byte is checked, (2) "overlong" encodings, (3) invalid "surrogate" values, and (4) invalid values in the first byte
-
hyc
fwiw, we've got comprehensive UTF8 validators/normalizers in the OpenLDAP source tree, if you want them
-
hyc
we found it was as much time to scan first for bad sequences, and copy, as it was to simply copy unconditionally (without scanning first)
-
moneromooo
Hrm. I'll leave it for now then.
-
luigi1111w
xiphon would you mind approving 6554 if it's how you want now?
-
xiphon
luigi1111w: on it
-
selsta
luigi1111w: it’s approved now
-
selsta
so I checked some of the down seed nodes, looks like fluffy added them 3 years ago
-
selsta
maybe he did forget about them
-
luigi1111w
thanks
-
selsta
vtnerd_: what is left so that the supercop PR can get merged?
-
selsta
(the one in the supercop repo)
-
selsta
only an approval?
-
moneromooo
IIRC I checked the asm but wanted luigi to check the crypto semantics.
-
moneromooo
(the C parts)
-
moneromooo
Other than that it was good to go.
-
selsta
I asked luigi to look at it
-
selsta
he did I think
-
moneromooo
(or someone else with crypto knowledge)
-
moneromooo
Oh good, then it can go in.
-
selsta
I tested it on my laptop and it works quite well so would be cool to get into the next major release :D
-
moneromooo
Except the assert might splatter key material onto the disk. Would be nice to remove it.
-
moneromooo
Can be done later I guess.
-
moneromooo
Approved.