00:08:30 <jtgrassie> needbrrrrrrr90: it can be used with a remote node too. doesn't have to be local.
00:09:06 <jtgrassie> it can even be used with remote public nodes (just like many do for their wallets)
00:09:36 <jtgrassie> hence one doesn't need to run their own local node to use self-select.
00:10:56 <needbrrrrrrr90> ah fantastic, xmrpow was implying that it required a full node
00:12:04 <needbrrrrrrr90> https://old.reddit.com/r/Monero/comments/ggywr1/skepticism_sunday_may_10_2020/fq80b26/?context=10
00:12:10 <needbrrrrrrr90> shilling your work jtgrassie :)
00:12:23 <needbrrrrrrr90> What are the major drawbacks, in your opinion?
00:12:52 <needbrrrrrrr90> I feel like I should be actively attempting to get this popular, unless there's some big drawback I'm missing
00:15:40 <jtgrassie> well the only real difference for a pool is they must validate the templates miners use, this is very fast though so not really a drawback.
00:16:06 <jtgrassie> for a miner, they need access to a node (local or remote).
00:16:19 <jtgrassie> which again, is really a non-issue.
00:17:28 <jtgrassie> the bigger reason uptake has not been that high I put down to the majority of the pools use that crappy nodejs pool, and nobody has bothered to implement it for that pool.
00:18:23 <jtgrassie> if one of the nodejs pool devs bothered to implement, we'd probably see much higher usage.
00:23:10 <jtgrassie> but then they can't add fast-mode randomx for share validation, I'm not holding my breath.
00:26:44 <dzimmerm> Is there any reason for me to upgrade the gui monero client to 15.04? I use opensuse leap 15.1 and there is a glibc version problem with the latest build of monero, opensuse leap 15.1 has version 2.26 and monero 15.04 wants version 2.27.
00:32:41 <moneromooo> What glibc version problem exactly ?
00:33:08 <moneromooo> Is this a gitian build ?
00:33:40 <moneromooo> IIRC gitian (or depends) wants a libc compatible with some particular verison, but later ones should be accepted too.
00:34:06 <dzimmerm> glibc.so.6 wants version 2.27, has version 2.26
00:34:27 <moneromooo> You've built the binary on the same box, right ?
00:34:50 <dzimmerm> checked and opensuse does not offer an update unless I change to tumbleweed.
00:34:52 <moneromooo> And did you update glibc after building ?
00:35:43 <dzimmerm> no update for glibc is offered for opensuse leap 15.1
00:36:09 <dzimmerm> I used the straight downloaded linux 64 bit version of monero. monero 15.02 runs fine
00:36:30 <moneromooo> Ah, there's your problem then. If you're going to develop for monero, build it yourself :)
00:37:20 <dzimmerm> I suck at Cmake, LOL. Ok, will build from source if I want the latest
00:38:01 <moneromooo> I *think* the GUI binaries will need whatever was on the machine where it was built since it does not use depends (which does some things to ensure backward compat with some versions of glibc).
00:39:03 <dzimmerm> I also have the issue with AMD ryzen 1600+ not liking randomX
00:39:09 <dzimmerm> saving for a newer processor
00:39:17 <selsta> GUI binaries were compiled on Ubuntu 18.04
00:39:57 <dzimmerm> ok, everyone loves Ubuntu. I am old Novel admin person so am partial to opensuse
00:40:50 <dzimmerm> thanks for the suggestions.
00:44:24 <dzimmerm> bye
02:08:28 <selsta> vtnerd: how can I compile the supercop benchmark?
02:09:29 <selsta> which cmake var?
02:12:23 <selsta> `MONERO_WALLET_CRYPTO_BENCH=cn` ?
02:31:56 <vtnerd> if you don't specify anything, then do `make monero-wallet-crypto-bench`
02:32:35 <vtnerd> probably need a readme for this
02:33:44 <vtnerd> if you specify no special parameters on the command-line, it chooses amd64-64-24k for the wallet backend, and does `cn amd64-51-30k` for the benchmark
02:34:12 <vtnerd> or sorry `cn amd64-51-30k amd64-64-24k` for the benchmark. but only on amd64 platforms
02:35:46 <vtnerd> if you want to do it manually then a cmake option `-DMONERO_WALLET_CRYPTO_BENCH="cn amd64-64-24k amd64-51-30k` is what to specify for amd64 (there are no other backends currently)
02:36:31 <vtnerd> the crypto bench is NOT in the default cmake target group, so doing `make` will never compile it by default
02:38:34 <vtnerd> the benchmark by default "depends on" every crypto backend available for the platform, so I removed it from the default make target so that only the backend in use (if any) gets built
03:12:44 <gingeropolous> bloody hell, i still got this on the release tagged thingy
03:12:45 <gingeropolous> 2020-05-11 03:12:22.194 E Failed to load hashes - unexpected data size
03:18:04 <gingeropolous> huzzah the 6514/15 PR worked
08:30:29 <rbrunner7> Any idea why two or more blanks lead to an empty element in the list returned by this method: wipeable_string::split(std::vector<wipeable_string> &fields)
08:30:58 <rbrunner7> No idea what this could be good for. I just now what is not good: Include 2 blanks anywhere in a seed to restore and it already fails. Bad UX, if you ask me
08:33:01 <rbrunner7> At least in core it seems that spliting method is only used for seeds; did not check the GUI
08:38:08 <selsta> rbrunner7: it should not, what version are you using?
08:38:30 <rbrunner7> HEAD
08:38:34 <selsta> oh wait, I read the code wrong
08:39:32 <rbrunner7> I think the intention is implemented correctly (2 or more blanks -> empty element in list), I just don't have any idea in what situations I would want that method to do that :)
08:39:50 <rbrunner7> And as I said, the result for seed is not very good
08:44:12 <rbrunner7> I think dEBRUYNE even has that in their standard arsenal of helpful questions if somebody reports that a restore by seed did not work: "Any double blanks?"
09:21:35 <rbrunner7> If my quick glance is correct the GUI seems to use JavaScript split(" ") which also would have the problem to fail with multiple blanks. For being robust a regular expression would probably be needed, like split(" +")
10:34:23 <dEBRUYNE> I call it redundant spaces :-P
10:34:25 <dEBRUYNE> ^ rbrunner7
10:36:59 <moneromooo> Does this fail ?
10:37:01 <moneromooo> ASSERT_TRUE(check_split("foo     bar   baz ", {"foo", "bar", "baz"}));
10:37:55 <moneromooo> tests/unit_tests/wipeable_string.cpp
10:38:08 <rbrunner7> Well, did not try, but I would say so, after my attempt to understand said method
10:38:58 <moneromooo> Then paste an example input giving bad results and I'll check.
10:55:15 <selsta> empty element gets added here: https://github.com/monero-project/monero/blob/master/contrib/epee/src/wipeable_string.cpp#L196
10:56:59 <rbrunner7> Yeah, but I just tried and could *not* get it to fail (again). Maybe I had some invisible characters in the input string, from editing. But then I start to doubt my capacity to understand C++ methods that are a mere 10 lines long :(
10:57:43 <rbrunner7> Alright, will debug. That's too much.
10:58:27 <rbrunner7> GUI might be completely different story, will check that afterwards.
10:58:47 <selsta> Adding a seed with spaces works here.
10:59:03 <selsta> rbrunner7: GUI uses the same split function
10:59:31 <rbrunner7> Alright, then my cursory analysis was wrong that it uses JavaScript for splitting seeds
11:05:27 <fluffypony> can't reproduce here, just restored with many spaces in the string
11:06:20 <selsta> I think the problem is when entering arrow keys and then deleting them again.
11:06:48 <moneromooo> Did you have a test case selsta ?
11:07:01 <fluffypony> ah yeah I've had issues with backspaces on password entry, but a loooong time ago
11:07:15 <fluffypony> might be an interaction with readline
11:07:16 <moneromooo> With readline or without ? If without, then it's expected.
11:07:17 <selsta> I don’t know how to do arrow keys in testcases.
11:07:37 <fluffypony> moneromooo: yeah was old builds pre-readline, iirc
11:07:49 <selsta> WIth readline. But readline does not seem to work during seed entry.
11:07:57 <selsta> It does work afterwards.
11:08:02 <fluffypony> oh hmmmm
11:08:08 <moneromooo> Ah, good point. It's raw entry to avoid leaving traces in memory.
11:08:13 <rbrunner7> Sorry then for making a fuss, blanks do work, I just worry about my mind not understanding a few lines of C++, but debugging and watching will surely help finally
11:09:59 <selsta> rbrunner7: I got confused too :D
11:10:32 <rbrunner7> And you know why blanks do not disturb? Did not see any logic higher up that filters out those empty array entries again ...
12:01:01 <rbrunner7> Before I make again a complete laughing stock out of myself: Can somebody please check whether the most recent GUI wallet accepts seeds with extra blanks in them?
12:01:09 <rbrunner7> With this seed: abbey  abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey
12:01:46 <rbrunner7> And then please try this: abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey abbey
12:03:02 <rbrunner7> (single difference should be a blank)
12:10:20 <rbrunner7> And of course that split method does not add empty entries. I was simply reading the code wrong, probably under the unconscious assumption that there *must* be something wrong with it. Sigh.
12:12:23 <selsta> rbrunner7: Can you explain?
12:12:41 <rbrunner7> Which? The latest sentence?
12:13:03 <selsta> `fields.push_back({});` looks like an empty element to me.
12:13:12 <selsta> But maybe I don’t understand it :)
12:14:43 <rbrunner7> Yes. It's the place where elements are created in the first place. They have to be created somehow, right? And after creating it letters are added to it. The "if (!blanks)" around that whole statement group filters out multiple blans
12:15:32 <rbrunner7> Had to actually debug and single-step through it until I could convince myself that there is no bug :)
12:16:02 <rbrunner7> Talk about the power of prejudice
12:17:14 <rbrunner7> But I still wait anxiously somebody checks multiple blanks on the GUI seed entry field ...
12:19:46 <selsta> Ok I get it now too. The second push_back is not the vector it’s for the wipeable_string.
12:20:47 <rbrunner7> Yes :)
12:20:51 <selsta> Both functions being called push_back confused me but it makes sense.
12:23:44 <selsta> rbrunner7: see here: https://github.com/monero-project/monero-gui/blob/1b7844ec345033b7809ef69ad941bd8a4a3986fb/js/Wizard.js#L111
12:24:02 <selsta> double space means you can’t enter the last word
12:24:38 <rbrunner7> ?
12:25:27 <selsta> I mean if you enter two spaces you can’t click on next
12:25:35 <rbrunner7> Yes.
12:25:44 <rbrunner7> What do you think about this behaviour?
12:25:52 <selsta> We tried the automatic stripping of double spaces but it did not work well
12:25:53 <selsta> https://github.com/monero-project/monero-gui/pull/2771
12:26:45 <rbrunner7> I see. That 'split' function on the line you give, is that JavaScript?
12:27:33 <rbrunner7> split(" ")
12:27:43 <selsta> yes but that is just the frontend, it uses wipeable_string afterwards
12:28:06 <rbrunner7> Ah ok. But if you don't get beyond this point that's for naught, right?
12:29:00 <rbrunner7> Please let me try split(" +") instead of split(" "). That could work. That might be my redemption for the fuss from me today here
12:45:29 <selsta> rbrunner7:  split(" +")? AFAIK split requires one separator and not regex.
12:46:18 <rbrunner7> I will check ... after my old creaky notebook finally finishes to compile the embedded Monero core ...
13:06:31 <rbrunner7> It's split(/\s+/)
13:06:48 <rbrunner7> Works like a charm
13:06:57 <rbrunner7> Will make a PR
13:19:09 <rbrunner7> Wow, cool new animation when checking for daemon still running :)
13:29:12 <rbrunner7> I checked that regular expression on this interactive playground first: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/split
16:24:21 * fluffypony hates regex
17:34:15 <moneromooo> Sooo... I've been looking every now and then just in case and... https://github.com/google/oss-fuzz/issues/2451
17:34:57 <moneromooo> It's an account with the ability to reopen a bug, so likely talking from a position of being able to back it up.
17:35:12 <moneromooo> Looks like fuzz tests are about to receive more attention ^_^
17:55:00 <dEBRUYNE> Nice one :D
17:55:41 <gingeropolous> curious - how does fuzz testing work with vulnerability reporting?
17:56:46 <gingeropolous> is there a human between that fuzz thing and reporting a bug, or does some machine just crawl github and fuzz everything and report bugs
17:56:56 <moneromooo> Coder runs fuzz tests. Fuzz tests find a crash or other. Coder tries to find an exploit for it. If found, coder reports to H1 os similar.
17:57:44 <moneromooo> You mean how google actually runs them themselves ? I think they have a doc explaining this somewhere, I saw that long ago. I think it's partly automated.
17:58:30 <gingeropolous> ah ok. so there's a human.
17:59:30 <rbrunner> "As of January 2020, OSS-Fuzz has found over 16,000 bugs in 250 open source projects." From their project page.
17:59:30 <moneromooo> At least an AI that can recognize bloody cars and traffic lights.
18:04:22 <asymptotically> i think that the guy that created AFL is working on an automated exploit thingy too :D
18:22:41 <moneromooo> Anyone's worked with oss-fuzz before ?
19:04:18 <luigi1111w> selsta do you want 6515 merged now?
19:26:23 <moneromooo> Docker downloads like 1 GB every build ? My god it can't be that stupid...
19:27:00 * moneromooo suspects a near future filled with swearting at shit
19:29:54 <scoobybejesus> most everything gets cached.. but if you blow it away, yup (though i never looked at how much it actually was)
19:30:37 <moneromooo> Well, if it errors out after downloading, it definitely slurps it again.
19:32:37 <sarang> I assume the commenter might be the same person as unseddd?
19:34:54 <moneromooo> Yes, they said they asked at the time.
19:35:22 <moneromooo> I thought it was pointless and a bit spammy, but looks like I was wrong ^_^
19:45:44 <dEBRUYNE> luigi1111w: I think he wanted to have it merged, yes
21:10:08 <xmrpow> Jtgrassie, are you there?
21:26:08 <selsta> luigi1111w: yes please
21:52:44 <moneromooo> Nice. It stopped downloading a gig after 5 times. It just has to fail a bit later.