-
vtnerd
selsta: yes, probably tomorrow though
-
moneromooo
Who should I prod to get the TXT records updated for update.getmonero.org ? Pony or was that handed around ?
-
ErCiccione[m]
i'm not sure, but binaryfate might have access ^
-
selsta
only fluffy has access at the moment
-
woodser_
the daemon seems to return multiple www-authenticate headers which causes requests from firefox to fail
-
woodser_
the daemon is started with: ./monerod --stagenet --rpc-login superuser:abctesting123 --rpc-access-control-origins
localhost:9100
-
woodser_
ideally firefox would handle the issue gracefully like the other browsers, but I'm looking to remove the duplicate from the response
-
TrasherDK
@woodser The daemon do the right thing. It's firefox fetch() api that's broken.
-
woodser_
I thought the firefox fetch() api was breaking because it can't parse the daemon's www-authenticate response header, which is either duplicated or separated by newlines instead of commas?
-
TrasherDK
I can see the wallet-rpc return 2 lines:
-
woodser_
-
TrasherDK
WWW-authenticate: Digest qop="auth",algorithm=MD5,realm="monero-rpc",nonce="k7VW9A39o7Dp7OjSnVCA/w==",stale=false
-
TrasherDK
WWW-authenticate: Digest qop="auth",algorithm=MD5-sess,realm="monero-rpc",nonce="k7VW9A39o7Dp7OjSnVCA/w==",stale=false
-
woodser_
I see the same from daemon responses
-
TrasherDK
The RFC nnnn says it's correct. But fetch() discard them as duplicates or something. I'll try to find the issue on the tracker...
-
TrasherDK
-
woodser_
while it's technically correct, and that issue should be resolved in firefox, we might be able to support firefox in the interim by cleaning up the response headers
-
TrasherDK
How about not using fetch at all? xmlhttprequest do not suffer from same bug.
-
woodser_
worth trying
-
TrasherDK
-
TrasherDK
When using xmlhttprequest one has to handle the construction of the auth response. Not that it's that hard..
-
vtnerd
selsta see PR 6407
-
selsta
thanks, trying it currently
-
moneromooo
What's the difference between std::string(host) and std::string{host} ? I tried the former and it did not help, and I thought it was the same.
-
vtnerd
it is, but maybe applied to the wrong line? the compiler was giving funky line numbers for some reason
-
vtnerd
I think the compiler was saying the line on get_host was the issue, but it was set_host
-
moneromooo
I did it for both the set and get IIRC. Even though it only moaned about one.
-
selsta
also C++ compiler error messages are useless
-
selsta
:D
-
moneromooo
Then I guess I messed up something else -_-
-
vtnerd
no it gives the correct line number
-
vtnerd
nah, they are extremely helpful, you just have to be a compiler writer to understand them
-
vtnerd
lol so I guess not very helpful most of the time
-
selsta
right, I guess you need a lot of experience to to appreciate them
-
vtnerd
the thing is they are often times giving the equivalent of stack traces for templates
-
selsta
do you know why this compiled on Windows?
-
vtnerd
so its quite noisy and you have to look at the bottom of the stack first
-
vtnerd
the tests arent built
-
selsta
or is release-static not building tests?
-
selsta
ok
-
vtnerd
its a cmake command to request it
-
moneromooo
Oh. I tried again, it does work, but the error comes up for a second similar case, I did not notice the liner number was further out.
-
selsta
luigi1111: can you merge #6407 to fix compilation? ty
-
binaryFate
Reminder meeting tomorrow 17 UTC
monero-project/meta #449
-
binaryFate
(take into account hour change tonight)
-
luigi1111w
done