FYI, in bulletproofs.cc there is a line that ends in two semicolons. Seems weird and useless. Is there some reason for it?

sc_mul(multiexp_data[i*2].scalar.bytes, a[ao+i].bytes, INV_EIGHT.bytes);;

No, it's just a do-nothing statement.

moneromooo: What vm will you as the most secure to test malware inside?

hypervisor*

qubes?

any are good. just be careful with things like 3d acceleration. at least with virtualbox's implementation, the guest can view things in video memory that weren't cleaned up properly

Creating a SSL key takes a second every startup. I'm thinking of adding a mode where it's created once and stored in the wallet cache to be reused later. It means the daemon knows which wallet connects again, but it's fine if it's your daemon.

Any opinion on this ? I think a passive adversary can also see what key is being used, right ?

Wouldn't the node already know which wallet it is from the IP address? Or are you thinking of wallets connecting to the node over TOR?

If you come from the same IP address, then the daemon can tell, sure (though not at the wallet level). With Tor, you would not need SSL.

is the key generation done in its own thread, or does it block progression? 1 second on an independent thread seems like not that big of a deal

Startup, blocking.

Maybe it's not that big a deal, true. It does add up, but I guess I load wallets much more often that the average.

But you can already re-use certificates by giving an option when starting the wallet, right?

You just want to make that the default, and generate/store a certificate if not given

Yes.

I've had the same problem due to frequent restarts and generated manually ssl certificate to avoid this delay.

I don't really see the added value, if you frequently restart the wallet you can already use a persistent certificate

Perhaps we could add a convenience option that checks for the certificate in the same directory as the wallet file, creates it if missing and otherwise loads it upon start

Something like --rpc-ssl-persist

That's mostly pointless. If you're going to add an argument, you can add the existing one.